From c61969bdef2b34d4e0a4fb86ff6e59da14073b4d Mon Sep 17 00:00:00 2001
From: Jack <jmilgate@turnitin.com>
Date: Wed, 2 Jul 2025 16:31:03 +0100
Subject: [PATCH] Checking for zero for submissionid

---
 turnitintooltwo_view.class.php | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/turnitintooltwo_view.class.php b/turnitintooltwo_view.class.php
index ba61fd51..f4de5db5 100755
--- a/turnitintooltwo_view.class.php
+++ b/turnitintooltwo_view.class.php
@@ -1378,10 +1378,6 @@ public function get_submission_inbox_row($cm, $turnitintooltwoassignment, $parts
         if ((!isset($submission->submission_objectid) || $turnitintooltwoassignment->turnitintooltwo->reportgenspeed != 0) &&
             empty($submission->nmoodle) && time() > $parts[$partid]->dtstart) {
 
-            if (empty($submission->submission_objectid)) {
-                $submission->submission_objectid = 0;
-            }
-
             $uploadtext = (!$istutor) ? html_writer::tag('span', get_string('submitpaper', 'turnitintooltwo')) : '';
 
             $eulaaccepted = 0;
@@ -1403,17 +1399,19 @@ public function get_submission_inbox_row($cm, $turnitintooltwoassignment, $parts
                 }
             }
 
+            $uploadid = isset($submission->submission_objectid) ? $submission->submission_objectid : 0;
+
             $upload = html_writer::link($CFG->wwwroot.'/mod/turnitintooltwo/view.php?id='.$cm->id.'&part='.$partid.'&user='.
                                     $submission->userid.'&do=submitpaper&view_context=box_solid', $uploadtext.' '.
                                     html_writer::tag('i', '', array('title' => get_string('submitpaper', 'turnitintooltwo'),
                                         'class' => 'fa fa-cloud-upload fa-lg')),
                                     array("class" => "upload_box nowrap",
-                                            "id" => "upload_".$submission->submission_objectid."_".$partid."_".$submission->userid,
+                                            "id" => "upload_".$uploadid."_".$partid."_".$submission->userid,
                                             'data-eula' => $eulaaccepted, 'data-user-type' => $istutor));
 
             $duedatepassed = time() > $parts[$partid]->dtdue;
             $latesubmissionsallowed = $turnitintooltwoassignment->turnitintooltwo->allowlate;
-            $submissionexists = empty($submission->submission_objectid);
+            $submissionexists = isset($submission->submission_objectid);
 
             // Show option to submit only when due date has passed, late submissions are allowed and student has not submitted.
             // An instructor will always have the ability to make a late submission - to account for student exemptions.