refactor: 💡 improve symfony config

Author: ttskch

config/esaba.yaml

@@ -26,13 +26,13 @@ parameters:
   env(PHP_ESABA_ENABLE_INDEXING): '%env(key:ESABA_ENABLE_INDEXING:json:ESABA_CONFIG)%'
 
   # actual configs
-  env(FINAL_ESA_TEAM_NAME): '%env(default:dotenv.ESA_TEAM_NAME:PHP_ESA_TEAM_NAME)%'
-  env(FINAL_ESA_ACCESS_TOKEN): '%env(default:dotenv.ESA_ACCESS_TOKEN:PHP_ESA_ACCESS_TOKEN)%'
-  env(FINAL_ESA_WEBHOOK_SECRET): '%env(default:dotenv.ESA_WEBHOOK_SECRET:PHP_ESA_WEBHOOK_SECRET)%'
-  env(FINAL_ESABA_PUBLIC_CATEGORIES): '%env(default:dotenv.ESABA_PUBLIC_CATEGORIES:PHP_ESABA_PUBLIC_CATEGORIES)%'
-  env(FINAL_ESABA_PUBLIC_TAGS): '%env(default:dotenv.ESABA_PUBLIC_TAGS:PHP_ESABA_PUBLIC_TAGS)%'
-  env(FINAL_ESABA_PRIVATE_CATEGORIES): '%env(default:dotenv.ESABA_PRIVATE_CATEGORIES:PHP_ESABA_PRIVATE_CATEGORIES)%'
-  env(FINAL_ESABA_PRIVATE_TAGS): '%env(default:dotenv.ESABA_PRIVATE_TAGS:PHP_ESABA_PRIVATE_TAGS)%'
-  env(FINAL_ESABA_HTML_REPLACEMENTS): '%env(default:dotenv.ESABA_HTML_REPLACEMENTS:PHP_ESABA_HTML_REPLACEMENTS)%'
-  env(FINAL_ESABA_USER_ASSETS): '%env(default:dotenv.ESABA_USER_ASSETS:PHP_ESABA_USER_ASSETS)%'
-  env(FINAL_ESABA_ENABLE_INDEXING): '%env(default:dotenv.ESABA_ENABLE_INDEXING:PHP_ESABA_ENABLE_INDEXING)%'
+  esa_team_name: '%env(string:default:dotenv.ESA_TEAM_NAME:PHP_ESA_TEAM_NAME)%'
+  esa_access_token: '%env(string:default:dotenv.ESA_ACCESS_TOKEN:PHP_ESA_ACCESS_TOKEN)%'
+  esa_webhook_secret: '%env(string:default:dotenv.ESA_WEBHOOK_SECRET:PHP_ESA_WEBHOOK_SECRET)%'
+  esaba_public_categories: '%env(json:default:dotenv.ESABA_PUBLIC_CATEGORIES:PHP_ESABA_PUBLIC_CATEGORIES)%'
+  esaba_public_tags: '%env(json:default:dotenv.ESABA_PUBLIC_TAGS:PHP_ESABA_PUBLIC_TAGS)%'
+  esaba_private_categories: '%env(json:default:dotenv.ESABA_PRIVATE_CATEGORIES:PHP_ESABA_PRIVATE_CATEGORIES)%'
+  esaba_private_tags: '%env(json:default:dotenv.ESABA_PRIVATE_TAGS:PHP_ESABA_PRIVATE_TAGS)%'
+  esaba_html_replacements: '%env(json:default:dotenv.ESABA_HTML_REPLACEMENTS:PHP_ESABA_HTML_REPLACEMENTS)%'
+  esaba_user_assets: '%env(json:default:dotenv.ESABA_USER_ASSETS:PHP_ESABA_USER_ASSETS)%'
+  esaba_enable_indexing: '%env(bool:default:dotenv.ESABA_ENABLE_INDEXING:PHP_ESABA_ENABLE_INDEXING)%'

config/packages/twig.yaml

@@ -4,7 +4,7 @@ twig:
     - 'form_theme/bootstrap_4_layout.html.twig'
     - 'form_theme/bootstrap_4_horizontal_layout.html.twig' # to be the default theme
   globals:
-    enable_indexing: '%env(bool:FINAL_ESABA_ENABLE_INDEXING)%'
+    enable_indexing: '%esaba_enable_indexing%'
 
 when@test:
   twig:

config/services.yaml

@@ -15,8 +15,8 @@ services:
     autowire: true      # Automatically injects dependencies in your services.
     autoconfigure: true # Automatically registers your services as commands, event subscribers, etc.
     bind:
-      string $teamName: '%env(string:FINAL_ESA_TEAM_NAME)%'
-      array $htmlReplacements: '%env(json:FINAL_ESABA_HTML_REPLACEMENTS)%'
+      string $teamName: '%esa_team_name%'
+      array $htmlReplacements: '%esaba_html_replacements%'
 
   # makes classes in src/ available to be used as services
   # this creates a service per class whose id is the fully-qualified class name
@@ -41,20 +41,20 @@ services:
   Polidog\Esa\Api:
     factory: [Polidog\Esa\Api, factory]
     arguments:
-      - '%env(string:FINAL_ESA_ACCESS_TOKEN)%'
-      - '%env(string:FINAL_ESA_TEAM_NAME)%'
+      - '%esa_access_token%'
+      - '%esa_team_name%'
 
   App\Esa\WebhookValidator:
     arguments:
-      - '%env(string:FINAL_ESA_WEBHOOK_SECRET)%'
+      - '%esa_webhook_secret%'
 
   App\Service\AccessController:
     arguments:
-      - '%env(json:FINAL_ESABA_PUBLIC_CATEGORIES)%'
-      - '%env(json:FINAL_ESABA_PUBLIC_TAGS)%'
-      - '%env(json:FINAL_ESABA_PRIVATE_CATEGORIES)%'
-      - '%env(json:FINAL_ESABA_PRIVATE_TAGS)%'
+      - '%esaba_public_categories%'
+      - '%esaba_public_tags%'
+      - '%esaba_private_categories%'
+      - '%esaba_private_tags%'
 
   App\Service\AssetResolver:
     arguments:
-      - '%env(json:FINAL_ESABA_USER_ASSETS)%'
+      - '%esaba_user_assets%'