-
Notifications
You must be signed in to change notification settings - Fork 46
feat: attempt to display ChildRef in OKD/OCP consolle #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: attempt to display ChildRef in OKD/OCP consolle #605
Conversation
Signed-off-by: tarilabs <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reviewer's GuideAdds a ChildResourceRef struct to LMEvalJobStatus to surface the created pod as a child resource in OKD/OCP consoles, updates the CRD schema and deepcopy implementations accordingly, and populates the new status field during reconciliation when the pod is created. Sequence diagram for updating LMEvalJob status with ChildResourceRef on pod creationsequenceDiagram
participant "LMEvalJobReconciler" as Reconciler
participant "LMEvalJob CR" as LMEvalJob
participant "Kubernetes API" as KubeAPI
participant "Pod" as Pod
Reconciler->>KubeAPI: "Create Pod for LMEvalJob"
KubeAPI-->>Reconciler: "Pod created"
Reconciler->>LMEvalJob: "Set status.state = ScheduledJobState"
Reconciler->>LMEvalJob: "Set status.podName = GetPodName()"
Reconciler->>LMEvalJob: "Set status.pod = ChildResourceRef{Kind='Pod', Namespace=job.Namespace, Name=GetPodName()}"
Reconciler->>KubeAPI: "Status().Update(LMEvalJob)"
KubeAPI-->>Reconciler: "LMEvalJob status updated with pod and podName"
Class diagram for updated LMEvalJobStatus and ChildResourceRefclassDiagram
class ChildResourceRef {
string Kind
string Name
string Namespace
}
class LMEvalJobStatus {
string podName
ChildResourceRef pod
JobState state
[]ProgressBar progressBars
}
LMEvalJobStatus *-- ChildResourceRef : pod
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
PR image build and manifest generation completed successfully! 📦 PR image: 📦 LMES driver image: 📦 LMES job image: 📦 Guardrails orchestrator image: 🗂️ CI manifests |
Signed-off-by: tarilabs <[email protected]>
Summary by Sourcery
Expose LMEvalJob child Pod information in the custom resource status to improve visibility in OKD/OCP consoles.
New Features:
Enhancements: