[Dev]: Dev<->Master (#4219)

satoshiotomakan · vcoolish · 10gic · web-flow · commit ed9152aa17a5 · 2025-01-17T01:12:43.000+01:00
* Kotlin multiplatform leaking memory (#4037) * Add deinit for KMP iOS and JVM targets * Add deinit for JS target * Add deinit for JS target * Fix JVM native name * Reuse one thread on JVM --------- Co-authored-by: satoshiotomakan <127754187+satoshiotomakan@users.noreply.github.com> * [KMP] Fix issue: memory leak found in Base58.decode in iOS (#4031) * Fix kmp issue: memory leak found in Base58.decode in iOS * Remove unused functions * Fix failed test cases * Revert "Fix failed test cases" This reverts commit 57eee39. * Revert val -> value argument name refactoring * Output better indentation * Revert changes in TWEthereumAbiFunction.h * Fix inconsistent naming --------- Co-authored-by: satoshiotomakan <127754187+satoshiotomakan@users.noreply.github.com> * [TON]: Add support for TON 24-words mnemonic (#3998) * feat(ton): Add support for TON 24-words mnemonic in Rust * feat(ton): Add tw_ton_wallet FFIs * feat(ton): Add TWTONWallet FFI in C++ * feat(ton): Add tonMnemonic StoredKey type * feat(ton): Add StoredKey TON tests * feat(ton): Add TWStoredKey TON tests * feat(ton): Add TONWallet support in Swift * TODO add iOS tests * feat(ton): Add `KeyStore` iOS tests * feat(ton): Add TONWallet support in JavaScript * Add `KeyStore` TypeScript tests * feat(ton): Remove `TonMnemonic` structure, replace with a `validate_mnemonic_words` function * [CI] Trigger CI * feat(ton): Fix rustfmt * feat(ton): Fix C++ build * feat(ton): Fix C++ build * feat(ton): Fix C++ build * feat(ton): Fix C++ address analyzer * feat(ton): Fix C++ tests * feat(ton): Add Android tests * feat(ton): Bump `actions/upload-artifact` to v4 * Bump `dawidd6/action-download-artifact` to v6 * feat(eth): Fix PR comments * Fix Java JVM leak (#4092) * [Chore]: Fix Android bindings (#4095) * [Chore]: Add GenericPhantomReference.java * [Chore]: Fix unnecessary null assertion in WalletCoreLibLoader.kt * Fix memory lead found in public key in kmp binding (#4097) * Update Callisto explorer (#4131) * Revert "[TON]: Add support for TON 24-words mnemonic (#3998)" (#4148) This reverts commit 0b16771. * Fix JVM synchronization issue (#4218) * Fix Java JVM leak * clean * apply to jni * [Misc]: Upgrade Rust toolchain to `nightly-2025-01-16` * [Misc]: Fix Clippy warnings --------- Co-authored-by: Satoshi Otomakan <satoshiotomakan8@gmail.com> * [Misc]: Fix Clippy warnings --------- Co-authored-by: Viacheslav Kulish <32914239+vcoolish@users.noreply.github.com> Co-authored-by: 10gic <github10gic@proton.me>
diff --git a/jni/java/wallet/core/java/GenericPhantomReference.java b/jni/java/wallet/core/java/GenericPhantomReference.java
@@ -4,12 +4,13 @@
 import java.lang.ref.ReferenceQueue;
 import java.util.Set;
 import java.util.HashSet;
+import java.util.Collections;
 
 public class GenericPhantomReference extends PhantomReference<Object> {
     private final long nativeHandle;
     private final OnDeleteCallback onDeleteCallback;
 
-    private static final Set<GenericPhantomReference> references = new HashSet<>();
+    private static final Set<GenericPhantomReference> references = Collections.synchronizedSet(new HashSet<>());
     private static final ReferenceQueue<Object> queue = new ReferenceQueue<>();
 
     static {
diff --git a/kotlin/wallet-core-kotlin/src/commonAndroidJvmMain/kotlin/com/trustwallet/core/GenericPhantomReference.kt b/kotlin/wallet-core-kotlin/src/commonAndroidJvmMain/kotlin/com/trustwallet/core/GenericPhantomReference.kt
@@ -2,6 +2,7 @@ package com.trustwallet.core
 
 import java.lang.ref.PhantomReference
 import java.lang.ref.ReferenceQueue
+import java.util.Collections
 
 internal class GenericPhantomReference private constructor(
     referent: Any,
@@ -10,7 +11,7 @@ internal class GenericPhantomReference private constructor(
 ) : PhantomReference<Any>(referent, queue) {
 
     companion object {
-        private val references: MutableSet<GenericPhantomReference> = HashSet()
+        private val references: MutableSet<GenericPhantomReference> = Collections.synchronizedSet(HashSet())
         private val queue: ReferenceQueue<Any> = ReferenceQueue()
 
         init {
diff --git a/rust/chains/tw_bitcoin/src/babylon/proto_builder/output_protobuf.rs b/rust/chains/tw_bitcoin/src/babylon/proto_builder/output_protobuf.rs
@@ -28,7 +28,7 @@ pub trait BabylonOutputProtobuf {
     ) -> SigningResult<TransactionOutput>;
 }
 
-impl<'a, Context: UtxoContext> BabylonOutputProtobuf for OutputProtobuf<'a, Context> {
+impl<Context: UtxoContext> BabylonOutputProtobuf for OutputProtobuf<'_, Context> {
     fn babylon_staking(
         &self,
         staking: &Proto::mod_OutputBuilder::StakingOutput,
diff --git a/rust/chains/tw_bitcoin/src/babylon/proto_builder/utxo_protobuf.rs b/rust/chains/tw_bitcoin/src/babylon/proto_builder/utxo_protobuf.rs
@@ -38,7 +38,7 @@ pub trait BabylonUtxoProtobuf {
     ) -> SigningResult<(TransactionInput, UtxoToSign)>;
 }
 
-impl<'a, Context: UtxoContext> BabylonUtxoProtobuf for UtxoProtobuf<'a, Context> {
+impl<Context: UtxoContext> BabylonUtxoProtobuf for UtxoProtobuf<'_, Context> {
     fn babylon_staking_timelock(
         &self,
         timelock: &Proto::mod_InputBuilder::StakingTimelockPath,
diff --git a/rust/chains/tw_solana/src/transaction/versioned.rs b/rust/chains/tw_solana/src/transaction/versioned.rs
@@ -189,7 +189,7 @@ impl<'de> Deserialize<'de> for MessagePrefix {
     {
         struct PrefixVisitor;
 
-        impl<'de> Visitor<'de> for PrefixVisitor {
+        impl Visitor<'_> for PrefixVisitor {
             type Value = MessagePrefix;
 
             fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
diff --git a/rust/frameworks/tw_ton_sdk/src/boc/binary_writer.rs b/rust/frameworks/tw_ton_sdk/src/boc/binary_writer.rs
@@ -54,7 +54,7 @@ impl BinaryWriter {
         } else {
             self.write_bytes(&data[..data_len - 1])?;
             let last_byte = data[data_len - 1];
-            let l = last_byte | 1 << (8 - rest_bits - 1);
+            let l = last_byte | (1 << (8 - rest_bits - 1));
             self.write(8, l)?;
         }
 
diff --git a/rust/frameworks/tw_ton_sdk/src/boc/raw.rs b/rust/frameworks/tw_ton_sdk/src/boc/raw.rs
@@ -263,7 +263,7 @@ fn write_raw_cell(
     if !full_bytes {
         writer.write_bytes(&data[..data_len_bytes - 1])?;
         let last_byte = data[data_len_bytes - 1];
-        let l = last_byte | 1 << (8 - padding_bits - 1);
+        let l = last_byte | (1 << (8 - padding_bits - 1));
         writer.write(8, l)?;
     } else {
         writer.write_bytes(data)?;
diff --git a/rust/tw_any_coin/src/wallet_connect_request.rs b/rust/tw_any_coin/src/wallet_connect_request.rs
@@ -16,8 +16,6 @@ impl WalletConnectRequest {
     #[inline]
     pub fn parse(coin: CoinType, input: &[u8]) -> SigningResult<Data> {
         let (ctx, entry) = coin_dispatcher(coin)?;
-        entry
-            .wallet_connect_parse_request(&ctx, input)
-            .map_err(SigningError::from)
+        entry.wallet_connect_parse_request(&ctx, input)
     }
 }
diff --git a/rust/tw_encoding/src/hex.rs b/rust/tw_encoding/src/hex.rs
@@ -30,7 +30,7 @@ pub trait DecodeHex {
     fn decode_hex(&self) -> FromHexResult<Data>;
 }
 
-impl<'a> DecodeHex for &'a str {
+impl DecodeHex for &str {
     fn decode_hex(&self) -> FromHexResult<Data> {
         decode(self)
     }
diff --git a/rust/tw_evm/src/message/eip712/message_types.rs b/rust/tw_evm/src/message/eip712/message_types.rs
@@ -38,7 +38,7 @@ pub struct CustomTypeBuilder<'a> {
     type_properties: &'a mut Vec<Property>,
 }
 
-impl<'a> CustomTypeBuilder<'a> {
+impl CustomTypeBuilder<'_> {
     pub fn add_property(&mut self, name: &str, property_type: PropertyType) -> &mut Self {
         self.type_properties.push(Property {
             name: name.to_string(),
diff --git a/rust/tw_misc/src/test_utils/json.rs b/rust/tw_misc/src/test_utils/json.rs
@@ -16,7 +16,7 @@ impl ToJson for Json {
     }
 }
 
-impl<'a> ToJson for Cow<'a, str> {
+impl ToJson for Cow<'_, str> {
     #[track_caller]
     fn to_json(&self) -> Json {
         self.as_ref().to_json()
@@ -30,7 +30,7 @@ impl ToJson for String {
     }
 }
 
-impl<'a> ToJson for &'a str {
+impl ToJson for &str {
     #[track_caller]
     fn to_json(&self) -> Json {
         serde_json::from_str(self).expect("Error on deserializing JSON from string")
diff --git a/tools/install-rust-dependencies b/tools/install-rust-dependencies
@@ -2,7 +2,7 @@
 
 set -e
 
-NIGHTLY="nightly-2024-06-13"
+NIGHTLY="nightly-2025-01-16"
 
 rustup toolchain install $NIGHTLY
 rustup default $NIGHTLY

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ pub trait BabylonOutputProtobuf {`
`28`	`28`	`) -> SigningResult<TransactionOutput>;`
`29`	`29`	`}`
`30`	`30`
`31`		`-impl<'a, Context: UtxoContext> BabylonOutputProtobuf for OutputProtobuf<'a, Context> {`
	`31`	`+impl<Context: UtxoContext> BabylonOutputProtobuf for OutputProtobuf<'_, Context> {`
`32`	`32`	`fn babylon_staking(`
`33`	`33`	`&self,`
`34`	`34`	`staking: &Proto::mod_OutputBuilder::StakingOutput,`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ pub trait BabylonUtxoProtobuf {`
`38`	`38`	`) -> SigningResult<(TransactionInput, UtxoToSign)>;`
`39`	`39`	`}`
`40`	`40`
`41`		`-impl<'a, Context: UtxoContext> BabylonUtxoProtobuf for UtxoProtobuf<'a, Context> {`
	`41`	`+impl<Context: UtxoContext> BabylonUtxoProtobuf for UtxoProtobuf<'_, Context> {`
`42`	`42`	`fn babylon_staking_timelock(`
`43`	`43`	`&self,`
`44`	`44`	`timelock: &Proto::mod_InputBuilder::StakingTimelockPath,`
Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ impl<'de> Deserialize<'de> for MessagePrefix {`
`189`	`189`	`{`
`190`	`190`	`struct PrefixVisitor;`
`191`	`191`
`192`		`- impl<'de> Visitor<'de> for PrefixVisitor {`
	`192`	`+ impl Visitor<'_> for PrefixVisitor {`
`193`	`193`	`type Value = MessagePrefix;`
`194`	`194`
`195`	`195`	`fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ impl BinaryWriter {`
`54`	`54`	`} else {`
`55`	`55`	`self.write_bytes(&data[..data_len - 1])?;`
`56`	`56`	`let last_byte = data[data_len - 1];`
`57`		`- let l = last_byte \| 1 << (8 - rest_bits - 1);`
	`57`	`+ let l = last_byte \| (1 << (8 - rest_bits - 1));`
`58`	`58`	`self.write(8, l)?;`
`59`	`59`	`}`
`60`	`60`
Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,6 @@ impl WalletConnectRequest {`
`16`	`16`	`#[inline]`
`17`	`17`	`pub fn parse(coin: CoinType, input: &[u8]) -> SigningResult<Data> {`
`18`	`18`	`let (ctx, entry) = coin_dispatcher(coin)?;`
`19`		`- entry`
`20`		`- .wallet_connect_parse_request(&ctx, input)`
`21`		`- .map_err(SigningError::from)`
	`19`	`+ entry.wallet_connect_parse_request(&ctx, input)`
`22`	`20`	`}`
`23`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ pub trait DecodeHex {`
`30`	`30`	`fn decode_hex(&self) -> FromHexResult<Data>;`
`31`	`31`	`}`
`32`	`32`
`33`		`-impl<'a> DecodeHex for &'a str {`
	`33`	`+impl DecodeHex for &str {`
`34`	`34`	`fn decode_hex(&self) -> FromHexResult<Data> {`
`35`	`35`	`decode(self)`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ pub struct CustomTypeBuilder<'a> {`
`38`	`38`	`type_properties: &'a mut Vec<Property>,`
`39`	`39`	`}`
`40`	`40`
`41`		`-impl<'a> CustomTypeBuilder<'a> {`
	`41`	`+impl CustomTypeBuilder<'_> {`
`42`	`42`	`pub fn add_property(&mut self, name: &str, property_type: PropertyType) -> &mut Self {`
`43`	`43`	`self.type_properties.push(Property {`
`44`	`44`	`name: name.to_string(),`