[FRONTEND] Improve namespacing of triton::gpu passes and libtriton modules#2817
Merged
[FRONTEND] Improve namespacing of triton::gpu passes and libtriton modules#2817
Conversation
shunting314
added a commit
to shunting314/triton
that referenced
this pull request
Mar 15, 2024
This commit cherry-pick PR triton-lang#3191 . It involves quite some manual work and is not a direct cherry pick. The reason is the original PR change ir.cc which was renamed from triton.cc by another PR triton-lang#2817 . Cherry pick PR triton-lang#2817 unfortunately cause a bunch of merge conflicts: https://gist.github.com/shunting314/bb84de294fa56d3f9e2b27fbf50f5f3b . With discussion with Oguz and Jason, we decide to do a manual cherry-pcik by applying the change to triton.cc directly. We are aware the ir module is under triton._C.libtriton.triton.ir while in latest version of triton it's under triton._C.libtriton.ir .
shunting314
added a commit
to shunting314/triton
that referenced
this pull request
Mar 19, 2024
This commit cherry-pick PR triton-lang#3191 . It involves quite some manual work and is not a direct cherry pick. The reason is the original PR change ir.cc which was renamed from triton.cc by another PR triton-lang#2817 . Cherry pick PR triton-lang#2817 unfortunately cause a bunch of merge conflicts: https://gist.github.com/shunting314/bb84de294fa56d3f9e2b27fbf50f5f3b . With discussion with Oguz and Jason, we decide to do a manual cherry-pcik by applying the change to triton.cc directly. We are aware the ir module is under triton._C.libtriton.triton.ir while in latest version of triton it's under triton._C.libtriton.ir .
binarman
pushed a commit
to binarman/triton
that referenced
this pull request
Apr 2, 2024
…dules (triton-lang#2817) Note: this moves compile_ptx_to_cubin from c++ to python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this moves compile_ptx_to_cubin from c++ to python