-
-
Notifications
You must be signed in to change notification settings - Fork 721
ci(core): fix Docker build errors on CI #6187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[no changelog]
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3B1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3T1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3W1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
Latest CI run: 19765302574
c095e13 to
f2b392e
Compare
f2b392e to
9d4223c
Compare
|
Suspicious that it always fails for T3*1 models. Is this becuase we're building secmon? Got any clues at which particular point does this happen? |
|
|
|
IIUC, since we build all the targets inside one |
IIUC, we build secmon only for T3W1 and D002: trezor-firmware/core/SConscript.secmon Lines 240 to 247 in 9d4223c
|
6326bb7 to
7150fb1
Compare
It fails during the following |
|
@matejcik @mmilata We shouldn't probably copy everything from trezor-firmware/build-docker.sh Line 287 in 7150fb1
|
|
IIRC it was useful when debugging why the build differs on two machines. But we can copy just the firmware images if it helps fixing CI. |
|
For consideration: building all targets in parallel brings down the pipeline time to ~12m: 316e7b8 https://github.com/trezor/trezor-firmware/actions/runs/19743054813. Fast but certainly the least efficient wrt total CPU time, also we'd have to combine the artifacts in another job probably. |
In some models, secmon is not built -> `secmon.bin` will be empty [1]. Use `-s` (instead of `-f`) to skip empty `.bin` files. [1] https://github.com/trezor/trezor-firmware/blob/9d4223c2613f0542716c45a02781bcac7e5803a2/core/SConscript.secmon#L240-L247 [no changelog]
It seems that copying the full `build/` directory may fail on CI: https://github.com/trezor/trezor-firmware/actions/runs/19740721662/job/56563676033 [no changelog]
7150fb1 to
127ea0c
Compare
|
Tested using a manual CI run: https://github.com/trezor/trezor-firmware/actions/runs/19765314523/job/56636556733. |






































Also, collect secmon fingerprint.