Skip to content

Conversation

@romanz
Copy link
Contributor

@romanz romanz commented Nov 26, 2025

Also, collect secmon fingerprint.

@romanz romanz self-assigned this Nov 26, 2025
@trezor-bot trezor-bot bot added this to Firmware Nov 26, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Nov 26, 2025
@github-actions
Copy link

github-actions bot commented Nov 26, 2025

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 19765302574

@romanz romanz force-pushed the romanz/docker-build-ci branch from c095e13 to f2b392e Compare November 27, 2025 12:53
@romanz romanz changed the title build(core): make Docker build less verbose ci(core): separate Docker builds by target Nov 27, 2025
@romanz romanz force-pushed the romanz/docker-build-ci branch from f2b392e to 9d4223c Compare November 27, 2025 13:59
@mmilata
Copy link
Member

mmilata commented Nov 27, 2025

Suspicious that it always fails for T3*1 models. Is this becuase we're building secmon? Got any clues at which particular point does this happen?

@mmilata
Copy link
Member

mmilata commented Nov 27, 2025

du -sh core/build

  • T2T1 1G
  • T2B1 1G
  • T3B1 1.2G
  • T3W1 1.5G

@romanz
Copy link
Contributor Author

romanz commented Nov 27, 2025

IIUC, since we build all the targets inside one docker run command, the storage is not being reclaimed until the docker run finishes.

@romanz
Copy link
Contributor Author

romanz commented Nov 27, 2025

Suspicious that it always fails for T3*1 models. Is this becuase we're building secmon?

IIUC, we build secmon only for T3W1 and D002:

if TREZOR_MODEL not in ['T3W1', 'D002']:
# Skipping build and creating empty secmon.bin
secmon_bin = env.Command(
target='secmon.bin',
source=[],
action=Touch('$TARGET')
)
Return()

@romanz romanz force-pushed the romanz/docker-build-ci branch 3 times, most recently from 6326bb7 to 7150fb1 Compare November 27, 2025 15:39
@romanz
Copy link
Contributor Author

romanz commented Nov 27, 2025

Got any clues at which particular point does this happen?

It fails during the following cp 👀
https://github.com/trezor/trezor-firmware/actions/runs/19740721662/job/56563676033
image

@romanz
Copy link
Contributor Author

romanz commented Nov 27, 2025

@matejcik @mmilata We shouldn't probably copy everything from build/ dir, right?

cp -r build/* /build

@mmilata
Copy link
Member

mmilata commented Nov 27, 2025

IIRC it was useful when debugging why the build differs on two machines. But we can copy just the firmware images if it helps fixing CI.

@mmilata
Copy link
Member

mmilata commented Nov 27, 2025

For consideration: building all targets in parallel brings down the pipeline time to ~12m: 316e7b8 https://github.com/trezor/trezor-firmware/actions/runs/19743054813. Fast but certainly the least efficient wrt total CPU time, also we'd have to combine the artifacts in another job probably.

@romanz romanz force-pushed the romanz/docker-build-ci branch from 7150fb1 to 127ea0c Compare November 28, 2025 13:32
@romanz romanz changed the title ci(core): separate Docker builds by target ci(core): fix Docker build errors on CI Nov 28, 2025
@romanz romanz linked an issue Nov 28, 2025 that may be closed by this pull request
@romanz
Copy link
Contributor Author

romanz commented Nov 28, 2025

@romanz romanz requested a review from mmilata November 28, 2025 13:51
@romanz romanz assigned matejcik and unassigned matejcik Nov 28, 2025
@romanz romanz requested a review from matejcik November 28, 2025 13:51
@romanz romanz marked this pull request as ready for review November 28, 2025 13:51
@romanz romanz requested a review from obrusvit as a code owner November 28, 2025 13:51
@romanz
Copy link
Contributor Author

romanz commented Nov 28, 2025

Build durations:
image

@romanz romanz merged commit 4e36f85 into main Nov 29, 2025
114 checks passed
@romanz romanz deleted the romanz/docker-build-ci branch November 29, 2025 08:43
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🤝 Needs QA

Development

Successfully merging this pull request may close these issues.

Docker builds are failing on CI

4 participants