Tropic wear leveling #6136
Open
Tropic wear leveling #6136
+149
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3B1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3W1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
Latest CI run: 19672792880
onvej-sl
force-pushed
the
onvej-sl/tropic-wear-leveling
branch
2 times, most recently
from
78944c4 to
44307f0
Compare
onvej-sl
force-pushed
the
onvej-sl/tropic-wear-leveling
branch
from
44307f0 to
0bd6f2e
Compare
onvej-sl
requested review from
andrewkozlik
and removed request for
TychoVrahe and
obrusvit
core/embed/sec/tropic/tropic.c
Outdated
| void tropic_pin_set_time(uint32_t *time_ms) { | ||
| rng_fill_buffer_strong_time(time_ms); | ||
| update_change_pin_counter_time(time_ms); | ||
| get_change_pin_counter_time(time_ms); |
Contributor
There was a problem hiding this comment.
Calling get_change_pin_counter_time() will give an incorrect result, because if the counter is not cached, then time will be added to the estimate, but in reality update_change_pin_counter() will have cached it, so it will be a no-op.
core/embed/sec/tropic/tropic.c
Outdated
| } | ||
|
|
||
| void tropic_pin_reset_slots_time(uint32_t *time_ms, uint16_t pin_index) { | ||
| get_change_pin_counter_time(time_ms); |
Contributor
There was a problem hiding this comment.
Calling get_change_pin_counter_time() will give an overestimate when the counter is not cached, because it will have already been cached in tropic_pin_stretch(), so in tropic_pin_reset_slots() it will be a no-op.
Co-authored-by: Andrew Kozlik <[email protected]>
|
Looks like you changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.