a draft example and some improvements #21
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 33 alerts and fixes 1 when merging f4dbffc into 860a037 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 33 alerts and fixes 1 when merging a97956d into 860a037 - view on LGTM.com new alerts:
fixed alerts:
|
skidzo
commented
Jan 6, 2020
Author
skidzo
left a comment
skidzo
left a comment
There was a problem hiding this comment.
looks good, still a lot of work to be done...
|
This pull request introduces 33 alerts and fixes 1 when merging c5b45d4 into 030895e - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please do not merge yet, leave it for now,
I will comment again when examples are ready with api changes...