Check 3.11 support (#2492)

Author: gaborbernat

.github/workflows/check.yml

@@ -17,6 +17,7 @@ jobs:
       fail-fast: false
       matrix:
         py:
+          - "3.11.0-rc.1"
           - "3.10"
           - "3.9"
           - "3.8"
@@ -45,12 +46,11 @@ jobs:
           python-version: ${{ matrix.py }}
       - name: Pick environment to run
         run: |
-          import json
-          import os
-          import subprocess
-          major, minor, impl = json.loads(subprocess.check_output(["python", "-c", "import json; import sys; import platform; print(json.dumps([sys.version_info[0], sys.version_info[1], platform.python_implementation()]));"], universal_newlines=True))
-          with open(os.environ['GITHUB_ENV'], 'a') as file_handler:
-                file_handler.write('TOXENV=' + ("py" if impl == "CPython" else "pypy") + ("{}{}".format(major, minor) if impl == "CPython" else "3") + "\n")
+          import os; import platform; import sys; from pathlib import Path
+          env = f'TOXENV=py{"" if platform.python_implementation() == "CPython" else "py"}3{sys.version_info.minor}'
+          print(f"Picked: {env} for {sys.version} based of {sys.executable}")
+          with Path(os.environ["GITHUB_ENV"]).open("ta") as file_handler:
+               file_handler.write(env)
         shell: python
       - name: Setup test suite
         run: tox r -vv --notest

docs/changelog/2492.feature.rst

@@ -0,0 +1 @@
+Pass ``PROGRAMDATA``,  ``PROGRAMFILES(x86)``, ``PROGRAMFILES`` environments on Windows by default as it is needed for discovering the VS C++ compiler and start testing against 3.11 - by :user:`gaborbernat`.

pyproject.toml

@@ -76,6 +76,7 @@ classifiers = [
   "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
+  "Programming Language :: Python :: 3.11",
   "Topic :: Software Development :: Libraries",
   "Topic :: Software Development :: Testing",
   "Topic :: Utilities",

src/tox/tox_env/python/api.py

@@ -87,6 +87,9 @@ def _default_pass_env(self) -> list[str]:
         if sys.platform == "win32":  # pragma: win32 cover
             env.extend(
                 [
+                    "PROGRAMDATA",  # needed for discovering the VS compiler
+                    "PROGRAMFILES(x86)",  # needed for discovering the VS compiler
+                    "PROGRAMFILES",  # needed for discovering the VS compiler
                     "SYSTEMDRIVE",
                     "SYSTEMROOT",  # needed for python's crypto module
                     "COMSPEC",  # needed for distutils cygwin compiler

tests/session/cmd/test_show_config.py

@@ -103,6 +103,9 @@ def test_pass_env_config_default(tox_project: ToxProjectCreator, stdout_is_atty:
         + (["MSYSTEM", "PATHEXT"] if is_win else [])
         + ["PIP_*"]
         + (["PROCESSOR_ARCHITECTURE"] if is_win else [])
+        + (["PROGRAMDATA"] if is_win else [])
+        + (["PROGRAMFILES"] if is_win else [])
+        + (["PROGRAMFILES(x86)"] if is_win else [])
         + ["REQUESTS_CA_BUNDLE", "SSL_CERT_FILE"]
         + (["SYSTEMDRIVE", "SYSTEMROOT", "TEMP"] if is_win else [])
         + (["TERM"] if stdout_is_atty else [])

tox.ini

@@ -1,6 +1,7 @@
 [tox]
 envlist =
     fix
+    py311
     py310
     py39
     py38
@@ -9,6 +10,7 @@ envlist =
     type
     docs
     pkg_meta
+isolated_build = true
 skip_missing_interpreters = true
 
 [testenv]
@@ -44,6 +46,11 @@ commands =
     pre-commit run --all-files --show-diff-on-failure {tty:--color=always} {posargs}
     python -c 'print(r"hint: run {envbindir}{/}pre-commit install to add checks as pre-commit hook")'
 
+[testenv:py311]
+setenv =
+    {[testenv]setenv}
+    AIOHTTP_NO_EXTENSIONS = 1
+
 [testenv:type]
 description = run type check on code base
 setenv =