Skip to content

Commit 47d1f9f

Browse files
zackman0010towolf
authored andcommitted
remotecfg: Fix errNotModified causing incorrect last_load metric and printing invalid error logs (grafana#2977)
Fixing behavior of errNotModified and remotecfg_last_load_successful metric. This also prevents invalid error log messages from being printed.
1 parent 77a47ef commit 47d1f9f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

internal/service/remotecfg/remotecfg.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ func (s *Service) fetchRemote() error {
383383
if err == nil {
384384
s.metrics.lastLoadSuccess.Set(1)
385385
s.metrics.lastFetchSuccessTime.SetToCurrentTime()
386-
} else {
386+
} else if err != errNotModified {
387387
s.metrics.totalFailures.Add(1)
388388
s.metrics.lastLoadSuccess.Set(0)
389389
return err

0 commit comments

Comments
 (0)