Skip to content

Commit 6fd7dd4

Browse files
namjaejeonsmfrench
authored andcommitted
ksmbd: fix kernel-doc warnings from ksmbd_conn_get/put()
The kernel test robot reported W=1 build warnings for ksmbd_conn_get() and ksmbd_conn_put() due to missing parameter descriptions. Add the @conn description to fix these warnings. Reported-by: kernel test robot <[email protected]> Signed-off-by: Namjae Jeon <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent a74668e commit 6fd7dd4

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

fs/smb/server/connection.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,8 @@ static void __ksmbd_conn_release_work(struct work_struct *work)
122122
/**
123123
* ksmbd_conn_get() - take a reference on @conn and return it.
124124
*
125+
* @conn: connection instance to get a reference to
126+
*
125127
* Returns @conn unchanged so callers can write
126128
* "fp->conn = ksmbd_conn_get(work->conn);" in one expression. Returns NULL
127129
* if @conn is NULL.
@@ -139,6 +141,8 @@ struct ksmbd_conn *ksmbd_conn_get(struct ksmbd_conn *conn)
139141
* ksmbd_conn_put() - drop a reference and, if it was the last, queue the
140142
* release onto ksmbd_conn_wq so it runs from process context.
141143
*
144+
* @conn: connection instance to put a reference to
145+
*
142146
* Callable from any context including RCU softirq callbacks and non-sleeping
143147
* locks; the actual release is deferred to the workqueue. ksmbd_conn_wq is
144148
* created in ksmbd_server_init() before any conn can be allocated and is

0 commit comments

Comments
 (0)