Skip to content

Commit a7b1056

Browse files
authored
🚩 Enable MM encoding feature by default for a… (#1029)
…ll platform <!-- markdownlint-disable --> ## Description Enable separate encoder for power by default. ## Related Issues <!-- Link related issues, e.g., `Fixes #` or `Relates to #456` --> ## Test Plan <!-- Describe how you tested your changes. Include commands or steps to reproduce. --> ## Checklist - [ ] I have read the [contributing guidelines](https://docs.vllm.ai/projects/spyre/en/latest/contributing) - [ ] My code follows the project's code style (run `bash format.sh`) - [ ] I have added tests for my changes (if applicable) - [ ] I have updated the documentation (if applicable) - [ ] My commits include a `Signed-off-by:` line (DCO compliance) --------- Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
1 parent 4a304fb commit a7b1056

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

sendnn_inference/envs.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
_cache: dict[str, Any] = {}
3737

38-
_CPU_MM_DTYPE_PLATFORM_DEFAULTS = {"s390x": "float32", "ppc64le": "bfloat16"}
38+
_CPU_MM_DTYPE_PLATFORM_DEFAULTS = {"s390x": "float32", "ppc64le": "float32"}
3939

4040

4141
def override(name: str, value: str) -> None:
@@ -184,12 +184,7 @@ def clear_env_cache():
184184
# its embedding is available. Only effective for decoder models with TP > 1.
185185
# Defaults to 0 (disabled) — uses the Phase 1 blocking encode path.
186186
"SENDNN_INFERENCE_ASYNC_MM_ENCODER": lambda: bool(
187-
int(
188-
os.getenv(
189-
"SENDNN_INFERENCE_ASYNC_MM_ENCODER",
190-
"0" if platform.machine() == "ppc64le" else "1",
191-
)
192-
)
187+
int(os.getenv("SENDNN_INFERENCE_ASYNC_MM_ENCODER", "1"))
193188
),
194189
# When "1" (default), rank 0 runs the vision encoder and shares the result
195190
# with other TP ranks via POSIX shared memory (one encoder call instead of

tests/utils/test_envs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def test_env_vars_override_for_invalid_config():
4848
"machine,expected",
4949
[
5050
("s390x", torch.float32),
51-
("ppc64le", torch.bfloat16),
51+
("ppc64le", torch.float32),
5252
("x86_64", torch.float16),
5353
("aarch64", torch.float16),
5454
],

0 commit comments

Comments
 (0)