Skip to content

Commit a2dc509

Browse files
mszyprowchanwoochoi
authored andcommitted
extcon: max8997: Fix lack of path setting in USB device mode
MAX8997 driver disables automatic path selection from MicroUSB connector and manually sets path to either UART or USB lines. However the code for setting USB path worked only for USB host mode (when ID pin is set to ground). When standard USB cable (USB device mode) is connected, path registers are not touched. This means that once the non-USB accessory is connected to MAX8997-operated micro USB port, the path is no longer set to USB and USB device mode doesn't work. This patch fixes it by setting USB path both for USB and USB host modes. Signed-off-by: Marek Szyprowski <[email protected]> Signed-off-by: Chanwoo Choi <[email protected]>
1 parent 3e34c81 commit a2dc509

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

drivers/extcon/extcon-max8997.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -311,12 +311,10 @@ static int max8997_muic_handle_usb(struct max8997_muic_info *info,
311311
{
312312
int ret = 0;
313313

314-
if (usb_type == MAX8997_USB_HOST) {
315-
ret = max8997_muic_set_path(info, info->path_usb, attached);
316-
if (ret < 0) {
317-
dev_err(info->dev, "failed to update muic register\n");
318-
return ret;
319-
}
314+
ret = max8997_muic_set_path(info, info->path_usb, attached);
315+
if (ret < 0) {
316+
dev_err(info->dev, "failed to update muic register\n");
317+
return ret;
320318
}
321319

322320
switch (usb_type) {

0 commit comments

Comments
 (0)