Skip to content

Commit b7eea73

Browse files
committed
net: add UdpSocket::peek_sender()
closes #5491
1 parent ee1c940 commit b7eea73

File tree

2 files changed

+112
-0
lines changed

2 files changed

+112
-0
lines changed

tokio/src/net/udp.rs

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1331,6 +1331,11 @@ impl UdpSocket {
13311331
/// Make sure to always use a sufficiently large buffer to hold the
13321332
/// maximum UDP packet size, which can be up to 65536 bytes in size.
13331333
///
1334+
/// MacOS will return an error if you pass a zero-sized buffer.
1335+
///
1336+
/// If you're merely interested in learning the sender of the data at the head of the queue,
1337+
/// try [`peek_sender`].
1338+
///
13341339
/// # Examples
13351340
///
13361341
/// ```no_run
@@ -1349,6 +1354,8 @@ impl UdpSocket {
13491354
/// Ok(())
13501355
/// }
13511356
/// ```
1357+
///
1358+
/// [`peek_sender`]: method@Self::peek_sender
13521359
pub async fn peek_from(&self, buf: &mut [u8]) -> io::Result<(usize, SocketAddr)> {
13531360
self.io
13541361
.registration()
@@ -1371,6 +1378,11 @@ impl UdpSocket {
13711378
/// Make sure to always use a sufficiently large buffer to hold the
13721379
/// maximum UDP packet size, which can be up to 65536 bytes in size.
13731380
///
1381+
/// MacOS will return an error if you pass a zero-sized buffer.
1382+
///
1383+
/// If you're merely interested in learning the sender of the data at the head of the queue,
1384+
/// try [`poll_peek_sender`].
1385+
///
13741386
/// # Return value
13751387
///
13761388
/// The function returns:
@@ -1382,6 +1394,8 @@ impl UdpSocket {
13821394
/// # Errors
13831395
///
13841396
/// This function may encounter any standard I/O error except `WouldBlock`.
1397+
///
1398+
/// [`poll_peek_sender`]: method@Self::poll_peek_sender
13851399
pub fn poll_peek_from(
13861400
&self,
13871401
cx: &mut Context<'_>,
@@ -1404,6 +1418,53 @@ impl UdpSocket {
14041418
Poll::Ready(Ok(addr))
14051419
}
14061420

1421+
/// Retrieve the sender of the data at the head of the input queue, waiting if empty.
1422+
///
1423+
/// This is equivalent to calling [`peek_from`] with a zero-sized buffer,
1424+
/// but suppresses the `WSAEMSGSIZE` error on Windows and the "invalid argument" error on macOS.
1425+
///
1426+
/// [`peek_from`]: method@Self::peek_from
1427+
pub async fn peek_sender(&self) -> io::Result<SocketAddr> {
1428+
self.io
1429+
.registration()
1430+
.async_io(Interest::READABLE, || {
1431+
self
1432+
.as_socket()
1433+
.peek_sender()?
1434+
.as_socket()
1435+
// Not clear what conditions could cause this,
1436+
// but we probably ought not to panic.
1437+
.ok_or_else(|| io::Error::new(io::ErrorKind::Other, "sender not available"))
1438+
})
1439+
.await
1440+
}
1441+
1442+
/// Retrieve the sender of the data at the head of the input queue.
1443+
///
1444+
/// This is equivalent to calling [`poll_peek_from`] with a zero-sized buffer,
1445+
/// but suppresses the `WSAEMSGSIZE` error on Windows and the "invalid argument" error on macOS.
1446+
///
1447+
/// # Notes
1448+
///
1449+
/// Note that on multiple calls to a `poll_*` method in the recv direction, only the
1450+
/// `Waker` from the `Context` passed to the most recent call will be scheduled to
1451+
/// receive a wakeup.
1452+
///
1453+
/// [`poll_peek_from`]: method@Self::poll_peek_from
1454+
pub fn poll_peek_sender(&self, cx: &mut Context<'_>) -> Poll<io::Result<SocketAddr>> {
1455+
self.io
1456+
.registration()
1457+
.poll_read_io(cx, || {
1458+
self
1459+
.as_socket()
1460+
.peek_sender()?
1461+
.as_socket()
1462+
// Not clear what conditions could cause this,
1463+
// but we probably ought not to panic.
1464+
.ok_or_else(|| io::Error::new(io::ErrorKind::Other, "sender not available"))
1465+
})
1466+
}
1467+
14071468
/// Gets the value of the `SO_BROADCAST` option for this socket.
14081469
///
14091470
/// For more information about this option, see [`set_broadcast`].

tokio/tests/udp.rs

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,57 @@ async fn send_to_peek_from_poll() -> std::io::Result<()> {
134134
Ok(())
135135
}
136136

137+
#[tokio::test]
138+
async fn peek_sender() -> std::io::Result<()> {
139+
let sender = UdpSocket::bind("127.0.0.1:0").await?;
140+
let receiver = UdpSocket::bind("127.0.0.1:0").await?;
141+
142+
let sender_addr = sender.local_addr()?;
143+
let receiver_addr = receiver.local_addr()?;
144+
145+
let msg = b"Hello, world!";
146+
sender.send_to(msg, receiver_addr).await?;
147+
148+
let peeked_sender = receiver.peek_sender().await?;
149+
assert_eq!(peeked_sender, sender_addr);
150+
151+
// Assert that `peek_sender()` returns the right sender but
152+
// doesn't remove from the receive queue.
153+
let mut recv_buf = [0u8; 32];
154+
let (read, received_sender) = receiver.recv_from(&mut recv_buf).await?;
155+
156+
assert_eq!(&recv_buf[..read], msg);
157+
assert_eq!(received_sender, peeked_sender);
158+
159+
Ok(())
160+
}
161+
162+
#[tokio::test]
163+
async fn poll_peek_sender() -> std::io::Result<()> {
164+
let sender = UdpSocket::bind("127.0.0.1:0").await?;
165+
let receiver = UdpSocket::bind("127.0.0.1:0").await?;
166+
167+
let sender_addr = sender.local_addr()?;
168+
let receiver_addr = receiver.local_addr()?;
169+
170+
let msg = b"Hello, world!";
171+
poll_fn(|cx| sender.poll_send_to(cx, msg, receiver_addr)).await?;
172+
173+
let peeked_sender = poll_fn(|cx| receiver.poll_peek_sender(cx)).await?;
174+
assert_eq!(peeked_sender, sender_addr);
175+
176+
// Assert that `poll_peek_sender()` returns the right sender but
177+
// doesn't remove from the receive queue.
178+
let mut recv_buf = [0u8; 32];
179+
let mut read = ReadBuf::new(&mut recv_buf);
180+
let received_sender = poll_fn(|cx| receiver.poll_recv_from(cx, &mut read)).await?;
181+
182+
assert_eq!(read.filled(), msg);
183+
assert_eq!(received_sender, peeked_sender);
184+
185+
Ok(())
186+
}
187+
137188
#[tokio::test]
138189
async fn split() -> std::io::Result<()> {
139190
let socket = UdpSocket::bind("127.0.0.1:0").await?;

0 commit comments

Comments
 (0)