Add auto increment keys and auto fields with UUID v4 or v7 #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@claude /pr-review |
|
Claude Code is working… I'll analyze this and get back to you. |
Returning NULL as the default is not ideal as we want to generally avoid NULL in favor of richer expressions.
…with the correct amount of fields
carllerche
reviewed
Nov 24, 2025
| /// These statements can reference fields from the inserted record using | ||
| /// `Expr::ParentField`. They execute after the parent INSERT but do not | ||
| /// affect the returned results. | ||
| pub then: Vec<Statement>, |
Member
There was a problem hiding this comment.
I know it was in the design doc. I would punt on it for the initial PR. I don't think any current test will require this to pass.
carllerche
reviewed
Nov 25, 2025
tests/tests/field_auto.rs
Outdated
| .await | ||
| .unwrap(); | ||
| assert_eq!(u.id, i); | ||
| assert_eq!(u.bars.get()[0].foo.get().id, i); |
Member
There was a problem hiding this comment.
foo.get() should not work here since the foo association is not eager loaded. You will need to issue a query to load it. I don't remember the API, maybe check another test file
# Conflicts: # crates/toasty-core/src/schema/builder/table.rs # crates/toasty-core/src/schema/db/ty.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.