forked from apache/incubator-kie-drools
-
Notifications
You must be signed in to change notification settings - Fork 1
Experiment : Dev new parser migrate03 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tkobayas
merged 50 commits into
tkobayas:dev-new-parser-tmp01
from
tkobayas2:dev-new-parser-migrate03
Feb 15, 2024
Merged
Experiment : Dev new parser migrate03 #8
tkobayas
merged 50 commits into
tkobayas:dev-new-parser-tmp01
from
tkobayas2:dev-new-parser-migrate03
Feb 15, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP * Ignore directories * Add debug. Minor modifications * WIP * Fix tests - add comments
* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code * Add ignored tokens to completion Co-authored-by: livio <[email protected]>
…ayas#5) - Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.
…kobayas#9) - Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL
- Add "DRL_" prefix for DRL keywords for clarification
…che#12) * Enhance test/grammar coverage. function, attributes, consequence - better getText preserving whitespaces - resolving WARNs because of overlapping keywords * - No need to declare duplicate keywords
apache#15) * Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice * - better test method names
…ache#16) * [DROOLS-7253] Review and improve drools-lsp parser Visitor design - Remove currentConstructStack. Utilize return object instead. * - Remove instance fields. Utilize return objects instead.
…iction (tkobayas#4) - Removed some unused cast
* [DROOLS-7287] Failed to parse comments in RHS * - add rhs string check
* [DROOLS-7515] Parser : Accept plain text in RHS * - Handle keyword token in RHS * - Removed sysout * - Revert statementKeywords. Instead, define DRL_END with newline or EOF * - fix method name
* [DROOLS-7288] Failed to parse complex parentheses - bump to 8.43.0.Final * additional tests
- Also covers [DROOLS-7303] Implement sliding window
- Also partially fixes [DROOLS-7302] Implement semicolon delimiter
- also covers [DROOLS-7291] Implement entry-point declaration - also covers window declaration
* [DROOLS-7306] Implement unification - Also [DROOLS-7307] Parse attribute agenda-group * [DROOLS-7308] Parse attribute without value - Also [DROOLS-7309] Parse attribute with parentheses
* [DROOLS-7310] parse nested parentheses * - Adding code commentes and explanations - Adding more nested level tests
apache#43) * [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser * removed syntax examples
…o drools (apache#44) - Add some methods to call from drools code base
* Add DescrDumperTest * Fix it
…o drools - New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package - To enable the new parser, run `mvn test -PDRL10` - At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration
- Revert an inappropriate test edit - Removed unnecessary profile - Clarify unsupported methods - Removed unnecessary bom dependency
tkobayas
pushed a commit
that referenced
this pull request
Dec 5, 2024
…he#6179) * More tests migrated * Migrated tests to Junit5 * Migrated serialization protobuf module * Migrated drools-ecj * Migrated drools persistance * Migrated drool traits tests * Migrated drools util module to Junit5 * Migrated drools xml support module to JUnit5 * Migrated kie internals to JUnit5 * Migrated kie memory compiler to JUnit5 * Migrated drools retediagram to JUnit5 * Migrated kie api to JUnit5
tkobayas
pushed a commit
that referenced
this pull request
Apr 30, 2025
…he#6179) * More tests migrated * Migrated tests to Junit5 * Migrated serialization protobuf module * Migrated drools-ecj * Migrated drools persistance * Migrated drool traits tests * Migrated drools util module to Junit5 * Migrated drools xml support module to JUnit5 * Migrated kie internals to JUnit5 * Migrated kie memory compiler to JUnit5 * Migrated drools retediagram to JUnit5 * Migrated kie api to JUnit5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.