Conversation
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 21 21
Lines 966 966
Branches 260 260
=======================================
Hits 873 873
Misses 75 75
Partials 18 18Continue to review full report at Codecov.
|
tkh44
approved these changes
Aug 20, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Add a preact-emotion package with react aliased to preact
Why:
We only use
createElementfrom react which preact exports but most people have react aliased to preact-compat so it's included anyway even if it's not needed.How:
Add a rollup config that aliases react to preact.
Checklist:
createElementand there isn't any seperate src