Skip to content

Commit fd00685

Browse files
committed
test(ethclient/gethclient): fix time sensitive test
REF: ethereum#25918
1 parent e22c2f6 commit fd00685

File tree

1 file changed

+20
-11
lines changed

1 file changed

+20
-11
lines changed

ethclient/gethclient/gethclient_test.go

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -110,34 +110,43 @@ func TestGethClient(t *testing.T) {
110110
name string
111111
test func(t *testing.T)
112112
}{
113-
{
114-
"TestAccessList",
115-
func(t *testing.T) { testAccessList(t, client) },
116-
},
117113
{
118114
"TestGetProof",
119115
func(t *testing.T) { testGetProof(t, client) },
120-
}, {
116+
},
117+
{
121118
"TestGCStats",
122119
func(t *testing.T) { testGCStats(t, client) },
123-
}, {
120+
},
121+
{
124122
"TestMemStats",
125123
func(t *testing.T) { testMemStats(t, client) },
126-
}, {
124+
},
125+
{
127126
"TestGetNodeInfo",
128127
func(t *testing.T) { testGetNodeInfo(t, client) },
129-
}, {
128+
},
129+
{
130130
"TestSetHead",
131131
func(t *testing.T) { testSetHead(t, client) },
132-
}, {
132+
},
133+
{
133134
"TestSubscribePendingTxs",
134135
func(t *testing.T) { testSubscribePendingTransactions(t, client) },
135-
}, {
136+
},
137+
{
136138
"TestCallContract",
137139
func(t *testing.T) { testCallContract(t, client) },
138140
},
141+
// The testaccesslist is a bit time-sensitive: the newTestBackend imports
142+
// one block. The `testAcessList` fails if the miner has not yet created a
143+
// new pending-block after the import event.
144+
// Hence: this test should be last, execute the tests serially.
145+
{
146+
"TestAccessList",
147+
func(t *testing.T) { testAccessList(t, client) },
148+
},
139149
}
140-
t.Parallel()
141150
for _, tt := range tests {
142151
t.Run(tt.name, tt.test)
143152
}

0 commit comments

Comments
 (0)