build for s390x architecture (aka IBM Mainframe)#28
Merged
Conversation
tianon
reviewed
Sep 27, 2016
| && eval "GOARCH=s390x go build $BUILD_FLAGS -o /go/bin/gosu-s390x" \ | ||
| && file /go/bin/gosu-s390x | ||
|
|
||
|
|
Owner
There was a problem hiding this comment.
Can you modify the whitespace to match the rest of the RUN instructions and delete this extra newline? (should only be a single newline in this space)
Contributor
Author
There was a problem hiding this comment.
Done...
Thanks !
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added a few lines in the "Dockerfile" to build for the s390x architecture.
Woud please consider pulling this to your code ?
Thanks
Kiran