Indexing cpu benchmark#1365
Merged
Merged
Conversation
Nabil-Salah
requested review from
AbdelrahmanElawady,
Eslam-Nawara,
Omarabdul3ziz,
ashraffouda,
mariobassem,
rawdaGastan,
sameh-farouk and
xmonader
as code owners
Nabil-Salah
force-pushed
the
development_index_cpu_benchmark
branch
2 times, most recently
from
9248446 to
e3aedd7
Compare
Nabil-Salah
force-pushed
the
development_index_cpu_benchmark
branch
from
e3aedd7 to
004bf66
Compare
Omarabdul3ziz
requested changes
Jun 11, 2025
| @@ -0,0 +1,54 @@ | |||
| package main | |||
Contributor
There was a problem hiding this comment.
is there a need for committing this file here?
| flag.UintVar(&f.dmiIndexerNumWorkers, "dmi-indexer-workers", 1, "number of workers checking on node dmi") | ||
| flag.UintVar(&f.speedIndexerIntervalMins, "speed-indexer-interval", 5, "node speed check interval in min") | ||
| flag.UintVar(&f.speedIndexerNumWorkers, "speed-indexer-workers", 100, "number of workers checking on node speed") | ||
| flag.UintVar(&f.cpuBenchmarkIndexerIntervalMins, "cpu-benchmark-indexer-interval", 5, "node cpu benchmark check interval in min") |
Contributor
There was a problem hiding this comment.
on node, the cpu benchmark runs every 6 hours, better to extend this interval
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
Omarabdul3ziz
approved these changes
Jun 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes introduced by this PR and what does it affect
Changes
List of changes this PR includes
Related Issues
#1285
Checklist