chore(deps): update dependency verify to v31

[thomhurst]

This PR contains the following updates:

Package	Type	Update	Change
Verify	nuget	major	30.20.1 -> 31.0.0

---

Release Notes

VerifyTests/Verify (Verify)

v31.0.0

Compare Source

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot.

[claude]

Claude finished @thomhurst's task —— View job

---

Code Review for Verify Dependency Update

Reviewing this major version update from Verify v30.20.1 to v31.0.0.

Todo List:

• Read the changed file (Directory.Packages.props)
• Search codebase for Verify usage and potential impacts
• Check test files that might use Verify
• Analyze for breaking changes and compatibility issues
• Provide comprehensive review feedback

Review Findings

⚠️ Critical Issue: Version Mismatch

The PR only updates the core Verify package to v31.0.0 but leaves related packages at v30.20.1:

• ✅ Verify → 31.0.0 (updated)
• ❌ Verify.NUnit → 30.20.1 (not updated)
• ❌ Verify.TUnit → 30.20.1 (not updated)

This version mismatch could cause runtime compatibility issues or unexpected behavior.

Code Quality Assessment

Positive aspects:

• This project has implemented custom verification logic rather than deep dependency on Verify internals
• Custom VerifyTUnit classes in /TUnit.PublicAPI/Verify.cs and /TUnit.Core.SourceGenerator.Tests/Verify.cs provide abstraction
• Only minimal direct usage of VerifyTests library found in codebase
• Good separation of concerns with custom snapshot testing implementation

Potential Issues

1. Breaking Changes Risk

• Major version updates (v30 → v31) typically contain breaking changes
• Without release notes visibility, cannot confirm API compatibility
• The custom implementation may shield from most breaking changes

2. Version Compatibility

• Verify.TUnit v30.20.1 may not be compatible with Verify v31.0.0
• Could lead to runtime errors or inconsistent behavior
• Verify.NUnit v30.20.1 has same compatibility concern

3. Test Coverage Impact

• Projects using Verify packages: TUnit.PublicAPI, TUnit.Core.SourceGenerator.Tests, TUnit.Assertions, TUnit.Assertions.SourceGenerator.Tests
• Snapshot tests could fail if there are serialization or format changes

Performance Considerations

• No apparent performance concerns with this dependency update
• Verify is primarily used for testing, not runtime execution

Security Assessment

• No security concerns identified with this dependency update
• Verify is a testing framework with no runtime security implications

Recommendations

1. Update all Verify packages together to ensure compatibility:

   <PackageVersion Include="Verify" Version="31.0.0" />
   <PackageVersion Include="Verify.NUnit" Version="31.0.0" />  
   <PackageVersion Include="Verify.TUnit" Version="31.0.0" />

2. Run snapshot tests after updating to ensure no breaking changes:

   dotnet test TUnit.Core.SourceGenerator.Tests
   dotnet test TUnit.PublicAPI  

3. Review Verify v31 release notes to understand breaking changes

4. Consider the custom verification implementation may need updates if Verify v31 changes core interfaces

Final Assessment

❌ Do not merge as-is - The partial update creates version incompatibility risks. Update all Verify packages together and validate with tests.