-
-
Notifications
You must be signed in to change notification settings - Fork 95
Fix missing --detailed-stacktrace option since v0.50.0 #2808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ktraceCommandProvider Co-authored-by: thomhurst <[email protected]>
Copilot
AI
changed the title
[WIP] Missing
Fix missing --detailed-stacktrace option since v0.50.0
Aug 6, 2025
--detailed-stacktrace since v0.50.0
Copilot finished work on behalf of
thomhurst
August 6, 2025 23:36
This was referenced Aug 7, 2025
This was referenced Sep 29, 2025
This was referenced Oct 6, 2025
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--detailed-stacktracecommand line option was inadvertently broken in v0.50.0 when the verbosity system was unified. TheDetailedStacktraceCommandProviderwas removed from registration but theTUnitMessageBusstill tried to check for the option, causing it to never work.Root Cause
In
TestApplicationBuilderExtensions.cs, the comment indicated that the unifiedVerbosityCommandProvider"replaces HideTestOutput, DisableLogo, DetailedStacktrace", and theDetailedStacktraceCommandProviderregistration was removed. However, theTUnitMessageBus.SimplifyStacktrace()method continued to check forDetailedStacktraceCommandProvider.DetailedStackTrace, which would always return false since the provider was no longer registered.Solution
This PR restores the
--detailed-stacktracefunctionality while maintaining the new unified verbosity system:DetailedStacktraceCommandProviderfor backward compatibilityTUnitMessageBusto check both the legacy--detailed-stacktraceflag and the newVerbosityService.ShowDetailedStackTracepropertyNullReferenceExceptionBehavior After Fix
--detailed-stacktrace: Works as before (backward compatible)--verbosity verboseor--verbosity debug: Also enables detailed stack traces (unified approach)--verbosity normalor--verbosity minimal: Standard behavior (no detailed traces)Both approaches work independently or together, providing full backward compatibility while supporting the modern verbosity system.
Testing
Fixes #2737.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.