fix: add DynamicallyAccessedMembers AOT annotations to Type parameters

thomhurst · claude · thomhurst · commit d612991bfa43 · 2026-01-26T22:58:16.000Z
Address PR review feedback:
- Add [DynamicallyAccessedMembers] attribute to Type parameters in
  non-generic GetOrCreate overloads for Native AOT compatibility
- Update public API snapshots with the new signatures

Co-Authored-By: Claude Opus 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/TUnit.Core/SharedDataSources.cs b/TUnit.Core/SharedDataSources.cs
@@ -1,3 +1,4 @@
+using System.Diagnostics.CodeAnalysis;
 using TUnit.Core.Helpers;
 
 namespace TUnit.Core;
@@ -105,7 +106,13 @@ public static T GetOrCreate<T>(SharedType sharedType, DataGeneratorMetadata data
     /// Thrown when <paramref name="key"/> is null/empty and <paramref name="sharedType"/> is <see cref="SharedType.Keyed"/>.
     /// </exception>
     /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="sharedType"/> is not a valid value.</exception>
-    public static object? GetOrCreate(SharedType sharedType, Type type, DataGeneratorMetadata dataGeneratorMetadata, string? key, Func<object?> factory)
+    public static object? GetOrCreate(
+        SharedType sharedType,
+        [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.NonPublicConstructors)]
+        Type type,
+        DataGeneratorMetadata dataGeneratorMetadata,
+        string? key,
+        Func<object?> factory)
     {
         var testClassType = TestClassTypeHelper.GetTestClassType(dataGeneratorMetadata);
         return GetOrCreate(sharedType, type, testClassType, key, factory);
@@ -125,7 +132,13 @@ public static T GetOrCreate<T>(SharedType sharedType, DataGeneratorMetadata data
     /// or when <paramref name="key"/> is null/empty and <paramref name="sharedType"/> is <see cref="SharedType.Keyed"/>.
     /// </exception>
     /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="sharedType"/> is not a valid value.</exception>
-    public static object? GetOrCreate(SharedType sharedType, Type type, Type? testClassType, string? key, Func<object?> factory)
+    public static object? GetOrCreate(
+        SharedType sharedType,
+        [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.NonPublicConstructors)]
+        Type type,
+        Type? testClassType,
+        string? key,
+        Func<object?> factory)
     {
         _ = type ?? throw new ArgumentNullException(nameof(type));
         _ = factory ?? throw new ArgumentNullException(nameof(factory));
diff --git a/TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.DotNet10_0.verified.txt b/TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.DotNet10_0.verified.txt
@@ -1200,8 +1200,8 @@ namespace
     }
     public static class SharedDataSources
     {
-        public static object? GetOrCreate(.SharedType sharedType,  type, ? testClassType, string? key, <object?> factory) { }
-        public static object? GetOrCreate(.SharedType sharedType,  type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }
+        public static object? GetOrCreate(.SharedType sharedType, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..NonPublicConstructors)]  type, ? testClassType, string? key, <object?> factory) { }
+        public static object? GetOrCreate(.SharedType sharedType, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..NonPublicConstructors)]  type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }
         public static T GetOrCreate<T>(.SharedType sharedType, ? testClassType, string? key)
             where T : new() { }
         public static T GetOrCreate<T>(.SharedType sharedType, .DataGeneratorMetadata dataGeneratorMetadata, string? key)
diff --git a/TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.DotNet8_0.verified.txt b/TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.DotNet8_0.verified.txt
@@ -1200,8 +1200,8 @@ namespace
     }
     public static class SharedDataSources
     {
-        public static object? GetOrCreate(.SharedType sharedType,  type, ? testClassType, string? key, <object?> factory) { }
-        public static object? GetOrCreate(.SharedType sharedType,  type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }
+        public static object? GetOrCreate(.SharedType sharedType, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..NonPublicConstructors)]  type, ? testClassType, string? key, <object?> factory) { }
+        public static object? GetOrCreate(.SharedType sharedType, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..NonPublicConstructors)]  type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }
         public static T GetOrCreate<T>(.SharedType sharedType, ? testClassType, string? key)
             where T : new() { }
         public static T GetOrCreate<T>(.SharedType sharedType, .DataGeneratorMetadata dataGeneratorMetadata, string? key)
diff --git a/TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.DotNet9_0.verified.txt b/TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.DotNet9_0.verified.txt
@@ -1200,8 +1200,8 @@ namespace
     }
     public static class SharedDataSources
     {
-        public static object? GetOrCreate(.SharedType sharedType,  type, ? testClassType, string? key, <object?> factory) { }
-        public static object? GetOrCreate(.SharedType sharedType,  type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }
+        public static object? GetOrCreate(.SharedType sharedType, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..NonPublicConstructors)]  type, ? testClassType, string? key, <object?> factory) { }
+        public static object? GetOrCreate(.SharedType sharedType, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..NonPublicConstructors)]  type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }
         public static T GetOrCreate<T>(.SharedType sharedType, ? testClassType, string? key)
             where T : new() { }
         public static T GetOrCreate<T>(.SharedType sharedType, .DataGeneratorMetadata dataGeneratorMetadata, string? key)
diff --git a/TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.Net4_7.verified.txt b/TUnit.PublicAPI/Tests.Core_Library_Has_No_API_Changes.Net4_7.verified.txt
@@ -1158,8 +1158,8 @@ namespace
     }
     public static class SharedDataSources
     {
-        public static object? GetOrCreate(.SharedType sharedType,  type, ? testClassType, string? key, <object?> factory) { }
-        public static object? GetOrCreate(.SharedType sharedType,  type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }
+        public static object? GetOrCreate(.SharedType sharedType, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..NonPublicConstructors)]  type, ? testClassType, string? key, <object?> factory) { }
+        public static object? GetOrCreate(.SharedType sharedType, [.(..None | ..PublicParameterlessConstructor | ..PublicConstructors | ..NonPublicConstructors)]  type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }
         public static T GetOrCreate<T>(.SharedType sharedType, ? testClassType, string? key)
             where T : new() { }
         public static T GetOrCreate<T>(.SharedType sharedType, .DataGeneratorMetadata dataGeneratorMetadata, string? key)

Original file line number	Diff line number	Diff line change
`@@ -1200,8 +1200,8 @@ namespace`
`1200`	`1200`	`}`
`1201`	`1201`	`public static class SharedDataSources`
`1202`	`1202`	`{`
`1203`		`- public static object? GetOrCreate(.SharedType sharedType, type, ? testClassType, string? key, <object?> factory) { }`
`1204`		`- public static object? GetOrCreate(.SharedType sharedType, type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }`
	`1203`	`+ public static object? GetOrCreate(.SharedType sharedType, [.(..None \| ..PublicParameterlessConstructor \| ..PublicConstructors \| ..NonPublicConstructors)] type, ? testClassType, string? key, <object?> factory) { }`
	`1204`	`+ public static object? GetOrCreate(.SharedType sharedType, [.(..None \| ..PublicParameterlessConstructor \| ..PublicConstructors \| ..NonPublicConstructors)] type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }`
`1205`	`1205`	`public static T GetOrCreate<T>(.SharedType sharedType, ? testClassType, string? key)`
`1206`	`1206`	`where T : new() { }`
`1207`	`1207`	`public static T GetOrCreate<T>(.SharedType sharedType, .DataGeneratorMetadata dataGeneratorMetadata, string? key)`
Original file line number	Diff line number	Diff line change
`@@ -1158,8 +1158,8 @@ namespace`
`1158`	`1158`	`}`
`1159`	`1159`	`public static class SharedDataSources`
`1160`	`1160`	`{`
`1161`		`- public static object? GetOrCreate(.SharedType sharedType, type, ? testClassType, string? key, <object?> factory) { }`
`1162`		`- public static object? GetOrCreate(.SharedType sharedType, type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }`
	`1161`	`+ public static object? GetOrCreate(.SharedType sharedType, [.(..None \| ..PublicParameterlessConstructor \| ..PublicConstructors \| ..NonPublicConstructors)] type, ? testClassType, string? key, <object?> factory) { }`
	`1162`	`+ public static object? GetOrCreate(.SharedType sharedType, [.(..None \| ..PublicParameterlessConstructor \| ..PublicConstructors \| ..NonPublicConstructors)] type, .DataGeneratorMetadata dataGeneratorMetadata, string? key, <object?> factory) { }`
`1163`	`1163`	`public static T GetOrCreate<T>(.SharedType sharedType, ? testClassType, string? key)`
`1164`	`1164`	`where T : new() { }`
`1165`	`1165`	`public static T GetOrCreate<T>(.SharedType sharedType, .DataGeneratorMetadata dataGeneratorMetadata, string? key)`