Fix rubocop

Author: thisismydesign

.rubocop.yml

@@ -6,10 +6,16 @@ AllCops:
   TargetRubyVersion: 3.1
   NewCops: enable
 
+# Named keyword arguments are used in many cases and names have to match
+Lint/UnusedBlockArgument:
+  Enabled: false
+
 # Do not enforce documentation
 Style/Documentation:
   Enabled: false
 
 # Disabled due to complex use cases
 RSpec/NestedGroups:
   Enabled: false
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false

lib/json/streamer/callbacks.rb

@@ -17,8 +17,8 @@ def start_array
         new_level([])
       end
 
-      def key(k, symbolize_keys)
-        @aggregator.key = symbolize_keys ? k.to_sym : k
+      def key(param, symbolize_keys)
+        @aggregator.key = symbolize_keys ? param.to_sym : param
       end
 
       def value(value)

lib/json/streamer/json_streamer.rb

@@ -19,6 +19,7 @@ def <<(data)
         parser << data
       end
 
+      # rubocop:disable Metrics/MethodLength
       def get(nesting_level: -1, key: nil, yield_values: true, symbolize_keys: false)
         conditions = Conditions.new(yield_level: nesting_level, yield_key: key)
         conditions.yield_value = ->(aggregator:, value:) { false } unless yield_values
@@ -40,7 +41,9 @@ def get(nesting_level: -1, key: nil, yield_values: true, symbolize_keys: false)
 
         unyielded_items
       end
+      # rubocop:enable Metrics/MethodLength
 
+      # rubocop:disable Metrics/MethodLength
       def get_with_conditions(conditions, options = {})
         @parser = Parser.new(@event_generator, symbolize_keys: options[:symbolize_keys])
         unyielded_items = []
@@ -57,6 +60,7 @@ def get_with_conditions(conditions, options = {})
 
         unyielded_items
       end
+      # rubocop:enable Metrics/MethodLength
 
       def aggregator
         parser.aggregator

lib/json/streamer/parser.rb

@@ -14,6 +14,8 @@ def initialize(event_generator, options = {})
         @event_consumer = Callbacks.new(@aggregator)
       end
 
+      # rubocop:disable Metrics/MethodLength
+      # rubocop:disable Metrics/AbcSize
       def get(conditions)
         @event_generator.start_object { @event_consumer.start_object }
         @event_generator.start_array { @event_consumer.start_array }
@@ -40,6 +42,8 @@ def get(conditions)
           end
         end
       end
+      # rubocop:enable Metrics/MethodLength
+      # rubocop:enable Metrics/AbcSize
 
       def <<(data)
         @event_generator << data

spec/json/streamer/conditions_spec.rb

@@ -13,42 +13,42 @@
   end
 
   RSpec.shared_examples 'yield' do |method|
-    context 'level' do
-      context 'true' do
+    context 'with level' do
+      context 'when true' do
         let(:level) { 1 }
         let(:yield_level) { 1 }
 
         it 'returns whether provided level equals yield_level' do
-          expect(conditions.send(method).call(aggregator: aggregator)).to be
+          expect(conditions.send(method).call(aggregator: aggregator)).to be_truthy
         end
       end
 
-      context 'false' do
+      context 'when false' do
         let(:level) { 2 }
         let(:yield_level) { 1 }
 
         it 'returns whether provided level equals yield_level' do
-          expect(conditions.send(method).call(aggregator: aggregator)).not_to be
+          expect(conditions.send(method).call(aggregator: aggregator)).to be_falsey
         end
       end
     end
 
-    context 'key' do
-      context 'true' do
+    context 'with key' do
+      context 'when true' do
         let(:key) { 'key' }
         let(:yield_key) { 'key' }
 
         it 'returns whether provided key equals yield_key' do
-          expect(conditions.send(method).call(aggregator: aggregator)).to be
+          expect(conditions.send(method).call(aggregator: aggregator)).to be_truthy
         end
       end
 
-      context 'false' do
+      context 'when false' do
         let(:key) { 'else' }
         let(:yield_key) { 'key' }
 
         it 'returns whether provided key equals yield_key' do
-          expect(conditions.send(method).call(aggregator: aggregator)).not_to be
+          expect(conditions.send(method).call(aggregator: aggregator)).to be_falsey
         end
       end
     end

spec/json/streamer/json_streamer_spec.rb

@@ -29,27 +29,27 @@
 
   describe '#<<' do
     it 'forwards data to parser' do
-      data = {}
       streamer = Json::Streamer.parser
+      allow(streamer).to receive(:<<)
 
-      expect(streamer.parser).to receive(:<<).with(data)
+      streamer << {}
 
-      streamer << data
+      expect(streamer).to have_received(:<<).with({})
     end
   end
 
   RSpec.shared_examples 'an iterable object' do
     let(:hash) { example_multi_level_hash }
 
     context 'when no block is passed' do
-      let(:subject) { streamer.send(method, **params) }
+      subject(:send) { streamer.send(method, **params) }
 
       it 'returns an Enumerable' do
-        expect(subject).to be_a(Enumerable)
+        expect(send).to be_a(Enumerable)
       end
 
       it 'returns array of items that would have been yielded' do
-        expect(subject).to eq(Array.new(3) { example_hash })
+        expect(send).to eq(Array.new(3) { example_hash })
       end
     end
 
@@ -63,7 +63,10 @@
 
     context 'when an empty block is passed' do
       it 'returns an empty Enumerable' do
+        # rubocop:disable Lint/EmptyBlock
         unyielded_objects = streamer.send(method, **params) {}
+        # rubocop:enable Lint/EmptyBlock
+
         expect(unyielded_objects).to eq([])
       end
     end
@@ -330,14 +333,14 @@
         let(:hash) { example_multi_level_hash }
 
         context 'when no block is passed' do
-          let(:subject) { streamer.send(method, params) }
+          subject(:send) { streamer.send(method, params) }
 
           it 'returns an Enumerable' do
-            expect(subject).to be_a(Enumerable)
+            expect(send).to be_a(Enumerable)
           end
 
           it 'returns array of items that would have been yielded' do
-            expect(subject).to eq(Array.new(3) { example_hash })
+            expect(send).to eq(Array.new(3) { example_hash })
           end
         end
 
@@ -351,7 +354,10 @@
 
         context 'when an empty block is passed' do
           it 'returns an empty Enumerable' do
+            # rubocop:disable Lint/EmptyBlock
             unyielded_objects = streamer.send(method, params) {}
+            # rubocop:enable Lint/EmptyBlock
+
             expect(unyielded_objects).to eq([])
           end
         end
@@ -419,6 +425,7 @@
 
   describe '#get (generated)' do
     context 'with JSONs with various nesting level and number of objects per level' do
+      # rubocop:disable RSpec/ExampleLength
       it 'yields all objects on desired level (checking number of yielded objects)' do
         # Setting these options to high can cause the test to run longer
         entries_per_level = 2
@@ -437,6 +444,7 @@
           expect(yielded_objects.length).to eq(entries_per_level**(max_level - 1))
         end
       end
+      # rubocop:enable RSpec/ExampleLength
     end
   end
 end

spec/json/streamer_memory_spec.rb

@@ -13,6 +13,8 @@
     let!(:json_file_mock) { StringIO.new(JSON.generate(hash)) }
 
     RSpec.shared_examples 'does not consumne memory' do
+      # rubocop:disable RSpec/ExampleLength
+      # rubocop:disable RSpec/MultipleExpectations
       it 'does not increase memory consumption' do
         p "Number of elements: #{size}"
         memory_usage_before_parsing = current_memory_usage
@@ -31,6 +33,8 @@
         expect(memory_usage_after_parsing).to be < 1.1 * memory_usage_before_parsing
         p 'With JSON::Streamer memory consumption did not increase by more than 10% during processing.'
       end
+      # rubocop:enable RSpec/ExampleLength
+      # rubocop:enable RSpec/MultipleExpectations
     end
 
     context 'with streaming' do
@@ -57,6 +61,8 @@
       context 'with array of objects parsed with JSON::Stream' do
         let(:content) { example_hash }
 
+        # rubocop:disable RSpec/MultipleExpectations
+        # rubocop:disable RSpec/ExampleLength
         it 'increases memory consumption' do
           p "Number of elements: #{size}"
           memory_usage_before_parsing = current_memory_usage
@@ -71,6 +77,8 @@
           expect(memory_usage_after_parsing).to be > 1.5 * memory_usage_before_parsing
           p 'With JSON::Stream memory consumption increased by at least 50% during processing.'
         end
+        # rubocop:enable RSpec/ExampleLength
+        # rubocop:enable RSpec/MultipleExpectations
       end
     end
   end

spec/json/streamer_spec.rb

@@ -6,19 +6,6 @@
       expect(described_class.parser).to be_a(Json::Streamer::JsonStreamer)
     end
 
-    it 'forwards parameters' do
-      json_file_mock = StringIO.new(JSON.generate(hash))
-      chunk_size = 10
-
-      custom_generator = Object.new
-      streamer = described_class.parser(file_io: json_file_mock, chunk_size: chunk_size,
-                                        event_generator: custom_generator)
-
-      expect(streamer.instance_variable_get(:@file_io)).to eq(json_file_mock)
-      expect(streamer.instance_variable_get(:@chunk_size)).to eq(chunk_size)
-      expect(streamer.instance_variable_get(:@event_generator)).to eq(custom_generator)
-    end
-
     it 'defaults to `JSON::Stream::Parser` event generator' do
       expect(described_class.parser.instance_variable_get(:@event_generator)).to be_a(JSON::Stream::Parser)
     end