Commit 9bb0ece
authored
Remove Linux orchestrator builds that only kick off one other build and wait (flutter#55186)
"Orchestrator" builders are top-level builds that can perform some caching, kick off "drone" sub-builds, and then do things with those build artifacts like run tests, or "generators" that do work on those artifacts. See more details in https://flutter.dev/go/engine-build-definition-language.
Some orchestrators in [`ci/builders`](https://github.com/flutter/engine/tree/38e37ce9879b2efe4890a8d09f4207dc5686a1bd/ci/builders) _only_ kick off one sub-build. This is suboptimal because:
1. The orchestrator uses a bot that does nothing except essentially idle.
2. The orchestrator has some overhead, so the orchestrator + single drone sub-build takes longer than just the sub-build run alone.
3. The "drone" sub-build often has a generic name like "Linux Engine Drone" which makes it difficult to keep track of which build is which.
This PR:
1. Hoists a few of these Linux builds into [`ci/builders/standalone`](https://github.com/flutter/engine/tree/38e37ce9879b2efe4890a8d09f4207dc5686a1bd/ci/builders/standalone) which are run as individual builds, and removes the orchestrator.
2. Swaps the recipe from `engine_v2/engine_v2` (orchestrator) to `engine_v2/builder` (standalone).
3. Moves the `drone_dimensions` from the orchestrator build json into .ci.yaml.
| Builder | Before | After |
| -------- | ------- | ------- |
| `Linux clangd` | [9m & 2 Linux bots](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20clangd/6272/overview) ([drone build](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/2689993/overview)) | [6m & 1 Linux bot](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20clangd/6292/overview) |
| `Linux linux_android_emulator_skia_tests_34` | [29m & 2 Linux bots](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_emulator_skia_tests_34/663/overview) ([drone build](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/2690008/overview)) | [25m & 1 Linux bot](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_emulator_skia_tests_34/678/overview) |
Part of flutter#155041
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style1 parent e8723f4 commit 9bb0ece
7 files changed
Lines changed: 205 additions & 228 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
| |||
118 | 119 | | |
119 | 120 | | |
120 | 121 | | |
121 | | - | |
| 122 | + | |
122 | 123 | | |
123 | 124 | | |
| 125 | + | |
124 | 126 | | |
125 | 127 | | |
126 | 128 | | |
| |||
382 | 384 | | |
383 | 385 | | |
384 | 386 | | |
385 | | - | |
| 387 | + | |
386 | 388 | | |
387 | 389 | | |
388 | 390 | | |
| |||
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
0 commit comments