fix: correct #137 hanging the tests on Windows (#139)

* fix: add a failing test

* fix: don't slice the root when it's the root directory

* fix: test both `sync` and `withPromise` properly

* chore: revert formatting changes

* fix: handle Windows root directories correctly

* chore: revert the formatting change

* chore: revert the formatting change

* chore: re-add the whitespace after the comma

* test: add an assertion to the test

* chore: revert the formatting change (sorry)

Author: pralkarz

__tests__/symlinks.test.ts

@@ -376,9 +376,13 @@ for (const type of apiTypes) {
 
     test(
       "doesn't hang when resolving symlinks in the root directory",
-      async () => {
+      async (t) => {
         const api = new fdir().withSymlinks({ resolvePaths: false }).crawl("/");
-        await api[type]();
+        const files = await api[type]();
+        const expectedFiles = normalize(["/lib/file-1", "/usr/lib/file-1"])
+        for (const expectedFile of expectedFiles) {
+          t.expect(files).toContain(expectedFile);
+        }
       },
       { timeout: 1000 }
     );

src/api/walker.ts

@@ -1,5 +1,5 @@
 import { basename, dirname } from "path";
-import { normalizePath } from "../utils";
+import { isRootDirectory, normalizePath } from "../utils";
 import { ResultCallback, WalkerState, Options } from "../types";
 import * as joinPath from "./functions/join-path";
 import * as pushDirectory from "./functions/push-directory";
@@ -37,7 +37,7 @@ export class Walker<TOutput extends Output> {
 
     this.root = normalizePath(root, options);
     this.state = {
-      root: this.root === "/" ? this.root : this.root.slice(0, -1),
+      root: isRootDirectory(this.root) ? this.root : this.root.slice(0, -1),
       // Perf: we explicitly tell the compiler to optimize for String arrays
       paths: [""].slice(0, 0),
       groups: [],

src/utils.ts

@@ -17,6 +17,10 @@ export function convertSlashes(path: string, separator: PathSeparator) {
   return path.replace(SLASHES_REGEX, separator);
 }
 
+export function isRootDirectory(path: string) {
+  return path === "/" || /^[a-z]:\\$/i.test(path);
+}
+
 export function normalizePath(
   path: string,
   options: {