feat: support no_std
#1
Open
+254
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Goal Allow the use of in no_std environments, particularly in smart contracts. # Solution The main culprit preventing the no_std was the use of `String` and `format`. To get around this I added a `std` feature and `arrayvec` which has `ArrayString` which allows allocating a `String` on the stack. # Future work One area that I would like to revisit is Errors. In my experience it's better for there to be more specific cases rather than general ones that use strings. This way callers can match against the error rather then inspect the inner string.
willemneal
force-pushed
the
feat/no_std
branch
from
1b6d5fc to
a5c493e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allow the use of in no_std environments, particularly in smart contracts.
Solution
The main culprit preventing the no_std was the use of
Stringandformat.To get around this I added a
stdfeature andarrayvecwhich hasArrayStringwhich allows allocating aStringon the stack.Future work
One area that I would like to revisit is Errors. In my experience it's better for there to be more specific cases rather than general ones that use strings. This way callers can match against the error rather then inspect the inner string.