Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

Problem: Missing debug_tranceBlockByHash RPC method and debug_traceBlock* may crash on non-existing block#743

Merged
fedekunze merged 9 commits into
evmos:mainfrom
calvinaco:feature/742-debug-trace-block-by-hash
Nov 12, 2021
Merged

Problem: Missing debug_tranceBlockByHash RPC method and debug_traceBlock* may crash on non-existing block#743
fedekunze merged 9 commits into
evmos:mainfrom
calvinaco:feature/742-debug-trace-block-by-hash

Conversation

@calvinaco

@calvinaco calvinaco commented Nov 11, 2021 •
edited by fedekunze
Loading

Copy link
Copy Markdown
Contributor

Closes #742 and closes #744

Description

Add the missing method

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@calvinaco
Problem: Missing debug_tranceBlockByHash RPC method
ada0df4 
Solution: (Fix evmos#742) Add the missing method
@calvinaco calvinaco changed the title Problem: Missing debug_tranceBlockByHash RPC method Problem: Missing debug_tranceBlockByHash RPC method and debug_traceBlock* may crash on non-existing block Nov 11, 2021
fedekunze
fedekunze reviewed Nov 11, 2021
View reviewed changes
Comment thread init.sh Outdated
Comment thread rpc/ethereum/namespaces/debug/api.go Outdated
Comment thread rpc/ethereum/namespaces/debug/api.go Outdated
calvinaco and others added 2 commits November 11, 2021 20:08
@calvinaco
Revert comment on init.sh
d708a5f
@calvinaco @fedekunze
Apply suggestions from code review
33d412c 
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
fedekunze
fedekunze reviewed Nov 11, 2021
View reviewed changes
Comment thread rpc/ethereum/backend/backend.go Outdated
fedekunze
fedekunze reviewed Nov 12, 2021
View reviewed changes
Comment thread rpc/ethereum/backend/backend.go Outdated
@fedekunze
fedekunze enabled auto-merge (squash) November 12, 2021 08:17
@fedekunze
fedekunze merged commit 481e3b8 into evmos:main Nov 12, 2021
@thomas-nguy thomas-nguy mentioned this pull request Nov 16, 2021
Closed
thomas-nguy referenced this pull request in crypto-org-chain/ethermint Nov 17, 2021
@calvinaco @fedekunze @thomas-nguy
cherry-pick (tharsis#743)
e520c6d 
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jolube jolube Awaiting requested review from jolube
@khoslaventures khoslaventures Awaiting requested review from khoslaventures
1 more reviewer
@fedekunze fedekunze fedekunze approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problem: debug_traceBlockByNumber crashed when block height not found Problem: Missing debug_tranceBlockByHash RPC method

2 participants

@calvinaco @fedekunze