fix(t8s-cluster/management-cluster): migrate missed field after upgrade

[cwrau]

Summary by CodeRabbit

• Chores
  • Reorganized internal configuration structure for improved clarity and maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A Helm chart template was restructured to nest the certificatesExpiryDays configuration under rollout.before instead of a flat rolloutBefore structure. The indentation and key path were adjusted accordingly, affecting 5 lines total with no functional impact to the kubeadmControlPlaneTemplate specification.

Changes

Cohort / File(s)	Summary
Helm Template Configuration charts/t8s-cluster/templates/management-cluster/clusterClass/kubeadmControlPlaneTemplate/_kubeadmControlPlaneTemplateSpec.yaml	Restructured YAML to convert flat rolloutBefore key to nested rollout.before structure. The certificatesExpiryDays setting retained under rollout.before with adjusted indentation. No functional changes to kubeadmConfigSpec or other fields.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

t8s-cluster

Suggested reviewers

• tasches
• marvinWolff
• teutonet-bot

Poem

🐰 A YAML refactor, nested and neat,
Rollout.before makes the config complete,
From flat to hierarchical, the structure aligns,
Certificates expire on perfectly indented lines! 📋✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: migrating a missed field in the t8s-cluster management-cluster after an upgrade, which aligns with the actual modification of the rolloutBefore field path.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adeb099 and ded1d18.

📒 Files selected for processing (1)

• charts/t8s-cluster/templates/management-cluster/clusterClass/kubeadmControlPlaneTemplate/_kubeadmControlPlaneTemplateSpec.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Agent
• GitHub Check: wait-for-checks

🔇 Additional comments (1)

charts/t8s-cluster/templates/management-cluster/clusterClass/kubeadmControlPlaneTemplate/_kubeadmControlPlaneTemplateSpec.yaml (1)

7-9: LGTM! Correct schema migration for KubeadmControlPlaneTemplate.

The nested rollout.before.certificatesExpiryDays structure is the correct path for Cluster API v1beta2's KubeadmControlPlaneTemplate spec. The 60-day value is a sensible default for triggering certificate renewal before rollout. Migration from the old flat format is complete across the codebase.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a configuration issue by migrating a field within the kubeadmControlPlaneTemplate specification. The change updates the structure of the rollout field, ensuring that the certificatesExpiryDays setting is properly nested, which is crucial for correct certificate management during cluster rollouts after an upgrade.

Highlights

• Configuration Field Migration: The rolloutBefore field in the kubeadmControlPlaneTemplate has been migrated to a nested structure under rollout.before.
• Certificate Expiry Setting: The certificatesExpiryDays setting is now correctly nested under the new rollout.before path, aligning with post-upgrade configuration requirements.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the KubeadmControlPlaneTemplate specification to align with an API upgrade, as indicated by the pull request title. The rolloutBefore field has been refactored into rollout.before. This change is consistent with API evolutions where related fields are grouped. The modification is concise, targeted, and appears to be a necessary fix to adapt to the new API version. I find no issues with this change.

[Copilot]

Pull request overview

This PR fixes a field structure that was missed during the migration to CAPI v1beta2. The rolloutBefore field in the KubeadmControlPlaneTemplate spec is being migrated to the correct nested structure rollout.before, which aligns with the v1beta2 API requirements.

Changes:

• Migrated rolloutBefore.certificatesExpiryDays to the nested structure rollout.before.certificatesExpiryDays in the KubeadmControlPlaneTemplate spec

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.