Skip to content

fix(base-cluster/monitoring): use correct grafana-tempo url#1881

Merged
cwrau merged 1 commit intomainfrom
fix/base-cluster/grafana-tempo-grafana-url
Jan 7, 2026
Merged

fix(base-cluster/monitoring): use correct grafana-tempo url#1881
cwrau merged 1 commit intomainfrom
fix/base-cluster/grafana-tempo-grafana-url

Conversation

@cwrau
Copy link
Member

@cwrau cwrau commented Jan 6, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Grafana Tempo datasource configuration to restore proper connectivity between monitoring and tracing components, ensuring trace queries resolve correctly and dashboard integrations function as expected.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 6, 2026 14:31
@cwrau cwrau enabled auto-merge January 6, 2026 14:31
@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

This PR updates the Grafana Tempo datasource URL endpoint from grafana-tempo-query-frontend.monitoring:3200 to grafana-tempo.monitoring:3200 in the monitoring/tracing configuration template.

Changes

Cohort / File(s) Summary
Grafana Tempo Configuration
charts/base-cluster/templates/monitoring/tracing/grafana-tempo.yaml
Updated datasource URL endpoint: grafana-tempo-query-frontend.monitoring:3200grafana-tempo.monitoring:3200

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • tasches
  • teutonet-bot
  • marvinWolff

Poem

🐰 I hopped through YAML, keen and spry,
The Tempo path I tuned with a sigh,
From query-frontend to tempo true,
Now traces find their way anew,
A tidy hop — the dashboard's cue!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: fixing the Grafana Tempo URL in the base-cluster monitoring configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64b9b05 and c421713.

📒 Files selected for processing (1)
  • charts/base-cluster/templates/monitoring/tracing/grafana-tempo.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • charts/base-cluster/templates/monitoring/tracing/grafana-tempo.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a configuration issue by correcting the URL for the Grafana Tempo datasource. This ensures that Grafana can properly connect to the Tempo tracing service, enabling accurate distributed tracing within the monitoring setup.

Highlights

  • Grafana Tempo URL Correction: The Grafana Tempo datasource URL in grafana-tempo.yaml has been updated to use the correct service name grafana-tempo instead of grafana-tempo-query-frontend.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Grafana Tempo datasource URL in the monitoring configuration by correcting the service name reference.

  • Changed the Tempo datasource URL from grafana-tempo-query-frontend.monitoring:3200 to grafana-tempo.monitoring:3200 to match the actual service name deployed by the HelmRelease

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the Grafana Tempo datasource URL. However, the proposed change to use grafana-tempo as the service name is incorrect, as the helm chart used does not create a service with this name for querying. The original service name grafana-tempo-query-frontend is correct, but it suffers from a bug in the specified chart version (1.24.1) where its selector doesn't match pods in the default monolithic deployment mode. I've provided a critical review comment explaining the issue and suggesting a proper fix, which involves correcting the service selector in the HelmRelease definition rather than changing the URL.

@cwrau cwrau force-pushed the fix/base-cluster/grafana-tempo-grafana-url branch from 64b9b05 to c421713 Compare January 7, 2026 10:14
@cwrau cwrau added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit e644bd2 Jan 7, 2026
31 of 32 checks passed
@cwrau cwrau deleted the fix/base-cluster/grafana-tempo-grafana-url branch January 7, 2026 10:53
github-merge-queue bot pushed a commit that referenced this pull request Jan 8, 2026
🤖 I have created a release *beep* *boop*
---


##
[11.0.1](base-cluster-v11.0.0...base-cluster-v11.0.1)
(2026-01-08)


### Bug Fixes

* **base-cluster/monitoring:** downgrade sidecar version to fix race
condition
([#1883](#1883))
([3044ba9](3044ba9))
* **base-cluster/monitoring:** use correct grafana-tempo url
([#1881](#1881))
([e644bd2](e644bd2))


### Miscellaneous Chores

* **base-cluster/dependencies:** update helm release
kube-prometheus-stack to v80
([#1868](#1868))
([1801d12](1801d12))
* **base-cluster/dependencies:** update helm release oauth2-proxy to
v9.0.1
([#1869](#1869))
([e6f2b7e](e6f2b7e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
  * Fixed race condition in sidecar component
  * Corrected Grafana Tempo URL configuration

* **Chores**
  * Updated kube-prometheus-stack to v80
  * Updated oauth2-proxy to v9.0.1

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants