fix(base-cluster/monitoring): use correct grafana-tempo url#1881
Conversation
📝 WalkthroughWalkthroughThis PR updates the Grafana Tempo datasource URL endpoint from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @cwrau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a configuration issue by correcting the URL for the Grafana Tempo datasource. This ensures that Grafana can properly connect to the Tempo tracing service, enabling accurate distributed tracing within the monitoring setup. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the Grafana Tempo datasource URL in the monitoring configuration by correcting the service name reference.
- Changed the Tempo datasource URL from
grafana-tempo-query-frontend.monitoring:3200tografana-tempo.monitoring:3200to match the actual service name deployed by the HelmRelease
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request aims to fix the Grafana Tempo datasource URL. However, the proposed change to use grafana-tempo as the service name is incorrect, as the helm chart used does not create a service with this name for querying. The original service name grafana-tempo-query-frontend is correct, but it suffers from a bug in the specified chart version (1.24.1) where its selector doesn't match pods in the default monolithic deployment mode. I've provided a critical review comment explaining the issue and suggesting a proper fix, which involves correcting the service selector in the HelmRelease definition rather than changing the URL.
64b9b05 to
c421713
Compare
🤖 I have created a release *beep* *boop* --- ## [11.0.1](base-cluster-v11.0.0...base-cluster-v11.0.1) (2026-01-08) ### Bug Fixes * **base-cluster/monitoring:** downgrade sidecar version to fix race condition ([#1883](#1883)) ([3044ba9](3044ba9)) * **base-cluster/monitoring:** use correct grafana-tempo url ([#1881](#1881)) ([e644bd2](e644bd2)) ### Miscellaneous Chores * **base-cluster/dependencies:** update helm release kube-prometheus-stack to v80 ([#1868](#1868)) ([1801d12](1801d12)) * **base-cluster/dependencies:** update helm release oauth2-proxy to v9.0.1 ([#1869](#1869)) ([e6f2b7e](e6f2b7e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed race condition in sidecar component * Corrected Grafana Tempo URL configuration * **Chores** * Updated kube-prometheus-stack to v80 * Updated oauth2-proxy to v9.0.1 <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.