fix(base-cluster): correctly set image repository

[marvinWolff]

Summary by CodeRabbit

• Chores
  • Standardized container image configuration to use a centralized registry field and separate repository/image fields in deployment values, replacing inlined image repository strings for clearer, more consistent image references across manifests.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[gemini-code-assist]

Summary of Changes

Hello @marvinWolff, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a configuration issue within the base-cluster Helm chart by correcting how the image repository for oauth2-proxy is defined. The change ensures that the image registry is properly set, preventing potential issues with image pulling and enhancing the robustness of deployments that utilize a custom image registry.

Highlights

• Image Repository Configuration: The pull request refactors the image repository configuration for the oauth2-proxy component within the kube-prometheus-stack.
• Explicit Registry Definition: The image.repository field has been split into separate registry and repository fields to correctly handle the image source, ensuring the global.imageRegistry value is applied as intended.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Introduces global.imageRegistry under values and removes the inline image.repository string composition in the oauth-proxy HelmRelease values, so the image registry is supplied via a centralized global value instead of being composed inline.

Changes

Cohort / File(s)	Summary
HelmRelease image registry propagation charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml	Added global.imageRegistry usage and removed the previous inline image.repository composition; image registry is now sourced from the global value instead of being concatenated into the repository string.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single-file change; templating adjustment only
• Review focus: verify value name (global.imageRegistry) and resulting image string rendering

Possibly related PRs

• chore(base-cluster/monitoring): migrate oauth2-proxy away from bitnami #1602 — modifies oauth-proxy HelmRelease image configuration in the same template (related change to image definition format)

Suggested reviewers

• tasches
• teutonet-bot
• cwrau

Poem

🐰 I hopped through YAML, neat and quick,
Pulled the registry out — a tidy trick.
Now global fields lead the way,
No more stitched repo in play,
Templates hum, and I nibble my carrot-stick. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(base-cluster): correctly set image repository' directly describes the main change: fixing the image repository configuration in the base-cluster by using global.imageRegistry instead of inline composition.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/base-cluster/fix-image-oauth-proxy

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a538f7b and a61534d.

📒 Files selected for processing (1)

• charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: check licenses
• GitHub Check: lint helm chart (base-cluster)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request correctly refactors the image configuration for oauth2-proxy by separating the registry and repository fields. This change aligns with standard Helm chart practices and resolves a potential bug where an incorrect image path could be generated. My review includes one suggestion to make the registry handling more robust.