fix(base-cluster/rbac): whitespace trimming by cwrau · Pull Request #1608 · teutonet/teutonet-helm-charts

cwrau · 2025-07-23T09:48:34Z

Summary by CodeRabbit

Style
- Improved formatting of rendered output in account-related configuration templates for better readability.

coderabbitai · 2025-07-23T09:48:41Z

Walkthrough

The change updates the whitespace control in Helm template delimiters within a YAML file. Only the placement of dashes in the end delimiters for if and range blocks is modified, impacting the formatting of the rendered template output without altering any logic or control flow.

Changes

File(s)	Change Summary
charts/base-cluster/templates/rbac/accounts.yaml	Adjusted whitespace control in Helm template delimiters; changed dash placement in `end` delimiters for formatting.

Estimated code review effort

1 (~2 minutes)

Poem

A dash to the left, a dash to the right,
Tidy templates gleam in the YAML light.
No logic was moved, no flow rearranged—
Just whitespace and lines, gently exchanged.
🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Pull Request Overview

This pull request fixes a whitespace/formatting issue in the RBAC service account template by correcting the indentation and trimming of template directives.

Corrects the indentation of the {{- end }} directive to align with proper YAML structure
Removes an incorrectly positioned {{ end -}} directive that was causing formatting issues

charts/base-cluster/templates/rbac/accounts.yaml

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

charts/base-cluster/templates/rbac/accounts.yaml (1)
23-24: Consider keeping the right-side dash on the if closing tag to suppress blank lines for skipped accounts

With {{- end }} the newline after the closing tag is preserved.
For iterations where the if condition is false (e.g. keys containing @), this results in an empty line being emitted for every skipped account.
While YAML tolerates blank lines, large value sets can lead to a noisy manifest and make diffing harder.

A minimal tweak eliminates the surplus whitespace without affecting valid iterations:
-  {{- end }}
+  {{- end -}}
The outer range already trims the trailing newline via {{ end -}}, so this change won’t re-introduce a final blank line at the end of the rendered file.
Please helm template the chart with a mixed rbac.accounts list to verify the output.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b29989 and 7dee2a4.

📒 Files selected for processing (1)

charts/base-cluster/templates/rbac/accounts.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: check licenses
GitHub Check: lint helm chart (base-cluster)
GitHub Check: wait-for-checks

🤖 I have created a release *beep* *boop* --- ## [8.2.1](base-cluster-v8.2.0...base-cluster-v8.2.1) (2025-07-24) ### Bug Fixes * **base-cluster/rbac:** whitespace trimming ([#1608](#1608)) ([4b028b4](4b028b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

fix(base-cluster/rbac): whitespace trimming

7dee2a4

Copilot AI review requested due to automatic review settings July 23, 2025 09:48

cwrau requested review from marvinWolff, tasches and teutonet-bot as code owners July 23, 2025 09:48

cwrau enabled auto-merge July 23, 2025 09:48

github-actions bot assigned cwrau Jul 23, 2025

github-actions bot added the base-cluster label Jul 23, 2025

Copilot AI reviewed Jul 23, 2025

View reviewed changes

charts/base-cluster/templates/rbac/accounts.yaml Show resolved Hide resolved

coderabbitai bot reviewed Jul 23, 2025

View reviewed changes

tasches approved these changes Jul 24, 2025

View reviewed changes

cwrau added this pull request to the merge queue Jul 24, 2025

Merged via the queue into main with commit 4b028b4 Jul 24, 2025
38 checks passed

cwrau deleted the fix/base-cluster/rbac-formatting branch July 24, 2025 09:27

teutonet-bot mentioned this pull request Jul 24, 2025

chore(main): [bot] release base-cluster:8.2.1 #1607

Merged

This was referenced Nov 28, 2025

chore(main): [bot] release base-cluster:10.1.2 #1841

Merged

chore(main): [bot] release base-cluster:11.0.0 #1862

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(base-cluster/rbac): whitespace trimming#1608

fix(base-cluster/rbac): whitespace trimming#1608
cwrau merged 1 commit intomainfrom
fix/base-cluster/rbac-formatting

cwrau commented Jul 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 23, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cwrau commented Jul 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cwrau commented Jul 23, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)