Add GHORG_FETCH_ALL check to no-clean mode processing (gabrie30#594)

The handleNoCleanMode function now only performs fetch-all operations if GHORG_FETCH_ALL is set to true, improving control over repository processing. Added tests to verify behavior when fetch-all is enabled and disabled.

Author: gabrie30

cmd/repository_processor.go

@@ -353,31 +353,34 @@ func (rp *RepositoryProcessor) handleBackupMode(repo *scm.Repo) bool {
 
 // handleNoCleanMode processes repositories in no-clean mode
 func (rp *RepositoryProcessor) handleNoCleanMode(repo *scm.Repo) bool {
-	// Temporarily restore credentials for fetch-all to work with private repos
-	err := rp.git.SetOriginWithCredentials(*repo)
-	if err != nil {
-		rp.addError(fmt.Sprintf("Problem trying to set remote with credentials: %s Error: %v", repo.URL, err))
-		return false
-	}
+	// Fetch all if enabled
+	if os.Getenv("GHORG_FETCH_ALL") == "true" {
+		// Temporarily restore credentials for fetch-all to work with private repos
+		err := rp.git.SetOriginWithCredentials(*repo)
+		if err != nil {
+			rp.addError(fmt.Sprintf("Problem trying to set remote with credentials: %s Error: %v", repo.URL, err))
+			return false
+		}
 
-	err = rp.git.FetchAll(*repo)
-	fetchErr := err // Store fetch error for later reporting
+		err = rp.git.FetchAll(*repo)
+		fetchErr := err // Store fetch error for later reporting
 
-	// Always strip credentials again for security, even if fetch failed
-	err = rp.git.SetOrigin(*repo)
-	if err != nil {
-		rp.addError(fmt.Sprintf("Problem trying to reset remote after fetch: %s Error: %v", repo.URL, err))
-		return false
-	}
+		// Always strip credentials again for security, even if fetch failed
+		err = rp.git.SetOrigin(*repo)
+		if err != nil {
+			rp.addError(fmt.Sprintf("Problem trying to reset remote after fetch: %s Error: %v", repo.URL, err))
+			return false
+		}
 
-	if fetchErr != nil && repo.IsWiki {
-		rp.addInfo(fmt.Sprintf("Wiki may be enabled but there was no content to clone on: %s Error: %v", repo.URL, fetchErr))
-		return false
-	}
+		if fetchErr != nil && repo.IsWiki {
+			rp.addInfo(fmt.Sprintf("Wiki may be enabled but there was no content to clone on: %s Error: %v", repo.URL, fetchErr))
+			return false
+		}
 
-	if fetchErr != nil {
-		rp.addError(fmt.Sprintf("Could not fetch remotes: %s Error: %v", repo.URL, fetchErr))
-		return false
+		if fetchErr != nil {
+			rp.addError(fmt.Sprintf("Could not fetch remotes: %s Error: %v", repo.URL, fetchErr))
+			return false
+		}
 	}
 
 	return true

cmd/repository_processor_test.go

@@ -325,6 +325,96 @@ func TestRepositoryProcessor_ProcessRepository_NoCleanMode(t *testing.T) {
 	}
 }
 
+func TestRepositoryProcessor_ProcessRepository_NoCleanModeWithFetchAllDisabled(t *testing.T) {
+	defer UnsetEnv("GHORG_")()
+	os.Setenv("GHORG_NO_CLEAN", "true")
+	os.Setenv("GHORG_FETCH_ALL", "false")
+
+	// Set up temporary directory with existing repo
+	dir, err := os.MkdirTemp("", "ghorg_test_no_clean_fetch_all_disabled")
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer os.RemoveAll(dir)
+
+	outputDirAbsolutePath = dir
+
+	// Create existing repo directory
+	repoDir := filepath.Join(dir, "test-repo")
+	err = os.MkdirAll(repoDir, 0755)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	mockGit := NewExtendedMockGit()
+	processor := NewRepositoryProcessor(mockGit)
+
+	repo := scm.Repo{
+		Name:        "test-repo",
+		URL:         "https://github.com/org/test-repo",
+		CloneBranch: "main",
+		HostPath:    repoDir,
+	}
+
+	repoNameWithCollisions := make(map[string]bool)
+	processor.ProcessRepository(&repo, repoNameWithCollisions, false, "test-repo", 0)
+
+	stats := processor.GetStats()
+	// In no-clean mode with fetch-all disabled, we should still process successfully
+	if stats.PulledCount != 1 {
+		t.Errorf("Expected pulled count to be 1, got %d", stats.PulledCount)
+	}
+	// Should not have any errors since fetch-all is skipped when disabled
+	if len(stats.CloneErrors) != 0 {
+		t.Errorf("Expected no errors when FETCH_ALL is disabled, got %d errors: %v", len(stats.CloneErrors), stats.CloneErrors)
+	}
+}
+
+func TestRepositoryProcessor_ProcessRepository_NoCleanModeWithFetchAllEnabled(t *testing.T) {
+	defer UnsetEnv("GHORG_")()
+	os.Setenv("GHORG_NO_CLEAN", "true")
+	os.Setenv("GHORG_FETCH_ALL", "true")
+
+	// Set up temporary directory with existing repo
+	dir, err := os.MkdirTemp("", "ghorg_test_no_clean_fetch_all_enabled")
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer os.RemoveAll(dir)
+
+	outputDirAbsolutePath = dir
+
+	// Create existing repo directory
+	repoDir := filepath.Join(dir, "test-repo")
+	err = os.MkdirAll(repoDir, 0755)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	mockGit := NewExtendedMockGit()
+	processor := NewRepositoryProcessor(mockGit)
+
+	repo := scm.Repo{
+		Name:        "test-repo",
+		URL:         "https://github.com/org/test-repo",
+		CloneBranch: "main",
+		HostPath:    repoDir,
+	}
+
+	repoNameWithCollisions := make(map[string]bool)
+	processor.ProcessRepository(&repo, repoNameWithCollisions, false, "test-repo", 0)
+
+	stats := processor.GetStats()
+	// In no-clean mode with fetch-all enabled, we should still process successfully
+	if stats.PulledCount != 1 {
+		t.Errorf("Expected pulled count to be 1, got %d", stats.PulledCount)
+	}
+	// Should not have any errors since fetch-all is enabled and mocked
+	if len(stats.CloneErrors) != 0 {
+		t.Errorf("Expected no errors when FETCH_ALL is enabled, got %d errors: %v", len(stats.CloneErrors), stats.CloneErrors)
+	}
+}
+
 func TestRepositoryProcessor_ProcessRepository_NameCollisions(t *testing.T) {
 	defer UnsetEnv("GHORG_")()