Skip to content

Conversation

@filipw01
Copy link
Contributor

BREAKING CHANGE: drops node 10 support

What:
Updated @testing-library/dom dependency and @testing-library/jest-dom dev dependency

Why:
Dependency requires some projects to have duplicate version of @testing-library/dom

How:
By updating package.json and updating engines entry

Checklist:

  • Documentation added N/A
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

BREAKING CHANGE: drops node 10 support
@orzechowskid
Copy link

I'd love to see this merged. being able to call
expect(screen.queryByRole('region', { description: 'my header text' }).not.toBeNull()
would be very nice in some of my unit tests, but the description property is not present in the Typescript definition files shipped with the version of @testing-library/dom currently used by @testing-library/preact.

@JoviDeCroock JoviDeCroock merged commit 4ccf063 into testing-library:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants