feat: Use new waitForWrapper around waitFor scope
#1369
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
sebbie/11-12-feat_use_new_waitforwrapper_around_waitfor_scope
branch
from
0036d22 to
d60b275
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8abda5a:
|
eps1lon
force-pushed
the
sebbie/11-12-feat_use_new_waitforwrapper_around_waitfor_scope
branch
from
d60b275 to
8abda5a
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
asyncWrapperis no longer used aroundwaitForscopeuser-eventhas started usingasyncWrapperaround small async steps. RTL needs to disable the act environment aroundwaitFor. We're resolving this conflict with a new wrapper specific towaitFor.RTL will use
waitForto disable act environment and configureasyncWrapperto useact. All user-event has to do is ensure it awaits thefireEventsince these are now async.