-
-
Notifications
You must be signed in to change notification settings - Fork 248
Fix Redis container to accept command override #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @ziggornif, yes please include the redis-stack command change in this PR |
Same as redis image with input command See issue #1150
|
Hi @cristianrgreco, I just made the modification for redis-stack as well. The REDIS_ARGS variable now contains the merge of the user's values with the default values. I kept the current solution of creating the variable via |
|
@cristianrgreco i remove the split maniplation, use I also update tests with Tell me if these changes correspond to what you wanted |
|
Thanks @ziggornif |
Hi,
Here's a small fix to resolve the Redis container startup issue with custom commands (#1150).
I noticed a similar issue with the redis-stack image that also overrides
this.createOpts.Env.Would you prefer I include this fix in the same PR, or should I create a separate issue to track it first?