fix: Send valid HTTP test responses #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Occasionally, the HTTP wait strategy tests fail. I did some testing using GitHub Codespaces and noticed that the HTTP response messages we use in our tests weren't being properly sent to the client. It looks like we are just sending
HTTP/1.1 200 OKwithout the newlines.I made a small adjustment to the
socatcontainer configuration we use to mimic an HTTP backend. It now sends a properly formatted HTTP-compliant response. I tested the changes for a while and the tests haven't failed since.Why is it important?
To keep the CI green.
Related issues
-