chore: Remove Sonar findings (#1450)

Author: HofmeisterAn

build/Parameters.cs

@@ -52,7 +52,7 @@ public static BuildParameters Instance(ICakeContext context)
             IsReleaseBuild = !buildInformation.IsLocalBuild && buildInformation.IsReleaseBuild,
             IsPullRequest = buildInformation.IsPullRequest,
             ShouldPublish = !buildInformation.IsLocalBuild && buildInformation.ShouldPublish,
-            Verbosity = DotNetVerbosity.Quiet,
+            Verbosity = DotNetVerbosity.Minimal,
             CodeSigningCertificateCredentials = BuildCredentials.GetCodeSigningCertificateCredentials(context),
             SonarQubeCredentials = SonarQubeCredentials.GetSonarQubeCredentials(context),
             NuGetCredentials = NuGetCredentials.GetNuGetCredentials(context),

src/Testcontainers/Containers/ExecFailedException.cs

@@ -1,4 +1,4 @@
-namespace DotNet.Testcontainers.Containers
+namespace DotNet.Testcontainers.Containers
 {
   using System;
   using System.Linq;
@@ -17,15 +17,15 @@ public sealed class ExecFailedException : Exception
     /// <summary>
     /// Initializes a new instance of the <see cref="ExecFailedException" /> class.
     /// </summary>
-    /// <param name="execResult">The result of the failed command execution.</param>
+    /// <param name="execResult">The result of the failed command.</param>
     public ExecFailedException(ExecResult execResult)
       : base(CreateMessage(execResult))
     {
       ExecResult = execResult;
     }
 
     /// <summary>
-    /// Gets the result of the failed command execution inside the container.
+    /// Gets the result of the failed command.
     /// </summary>
     public ExecResult ExecResult { get; }
 

src/Testcontainers/Containers/ExecResultExtensions.cs

@@ -1,4 +1,4 @@
-namespace DotNet.Testcontainers.Containers
+namespace DotNet.Testcontainers.Containers
 {
   using System;
   using System.Threading.Tasks;

tests/Testcontainers.ActiveMq.Tests/ArtemisContainerTest.cs

@@ -22,9 +22,12 @@ await _artemisContainer.StartAsync()
             .ConfigureAwait(false);
     }
 
-    public ValueTask DisposeAsync()
+    public async ValueTask DisposeAsync()
     {
-        return _artemisContainer.DisposeAsync();
+        await DisposeAsyncCore()
+            .ConfigureAwait(false);
+
+        GC.SuppressFinalize(this);
     }
     // # --8<-- [end:UseArtemisContainer]
 
@@ -73,6 +76,11 @@ await producer.SendAsync(producedMessage)
     }
     // # --8<-- [end:ArtemisContainerEstablishesConnection]
 
+    protected virtual ValueTask DisposeAsyncCore()
+    {
+        return _artemisContainer.DisposeAsync();
+    }
+
     // # --8<-- [start:UseArtemisContainerDefaultAuth]
     [UsedImplicitly]
     public sealed class DefaultCredentialsConfiguration : ArtemisContainerTest

tests/Testcontainers.Azurite.Tests/AzuriteContainerTest.cs

@@ -15,9 +15,12 @@ await _azuriteContainer.StartAsync()
             .ConfigureAwait(false);
     }
 
-    public ValueTask DisposeAsync()
+    public async ValueTask DisposeAsync()
     {
-        return _azuriteContainer.DisposeAsync();
+        await DisposeAsyncCore()
+            .ConfigureAwait(false);
+
+        GC.SuppressFinalize(this);
     }
 
     [Fact]
@@ -65,6 +68,11 @@ public async Task EstablishesTableServiceConnection()
         Assert.False(HasError(properties));
     }
 
+    protected virtual ValueTask DisposeAsyncCore()
+    {
+        return _azuriteContainer.DisposeAsync();
+    }
+
     private static bool HasError<TResponseEntity>(NullableResponse<TResponseEntity> response)
     {
         using (var rawResponse = response.GetRawResponse())
@@ -104,6 +112,7 @@ public AzuriteMemoryLimitConfiguration()
         }
 
         [Fact]
+        [Trait(nameof(DockerCli.DockerPlatform), nameof(DockerCli.DockerPlatform.Linux))]
         public async Task MemoryLimitIsConfigured()
         {
             // Given

tests/Testcontainers.Commons/DockerCli.cs

@@ -44,7 +44,7 @@ public enum DockerResource
     public static bool PlatformIsEnabled(DockerPlatform platform)
     {
         var commandResult = new Command("version", "--format {{.Server.Os}}").Execute();
-        return 0.Equals(commandResult.ExitCode) && commandResult.Stdout.Contains(platform.ToString().ToLowerInvariant());
+        return 0.Equals(commandResult.ExitCode) && commandResult.Stdout.Contains(platform.ToString(), StringComparison.OrdinalIgnoreCase);
     }
 
     public static bool ResourceExists(DockerResource resource, string id)

tests/Testcontainers.Db2.Tests/DeclineLicenseAgreementTest.cs

@@ -6,13 +6,15 @@ public sealed partial class DeclineLicenseAgreementTest
     private static partial Regex LicenseAgreementNotAccepted();
 
     [Fact]
+    [Trait(nameof(DockerCli.DockerPlatform), nameof(DockerCli.DockerPlatform.Linux))]
     public void WithoutAcceptingLicenseAgreementThrowsArgumentException()
     {
         var exception = Assert.Throws<ArgumentException>(() => new Db2Builder().Build());
         Assert.Matches(LicenseAgreementNotAccepted(), exception.Message);
     }
 
     [Fact]
+    [Trait(nameof(DockerCli.DockerPlatform), nameof(DockerCli.DockerPlatform.Linux))]
     public void WithLicenseAgreementDeclinedThrowsArgumentException()
     {
         var exception = Assert.Throws<ArgumentException>(() => new Db2Builder().WithAcceptLicenseAgreement(false).Build());

tests/Testcontainers.EventHubs.Tests/EventHubsContainerTest.cs

@@ -20,9 +20,12 @@ await _eventHubsContainer.StartAsync()
             .ConfigureAwait(false);
     }
 
-    public ValueTask DisposeAsync()
+    public async ValueTask DisposeAsync()
     {
-        return _eventHubsContainer.DisposeAsync();
+        await DisposeAsyncCore()
+            .ConfigureAwait(false);
+
+        GC.SuppressFinalize(this);
     }
 
     private static EventHubsServiceConfiguration GetServiceConfiguration()
@@ -63,6 +66,11 @@ await producer.SendAsync(eventDataBatch, TestContext.Current.CancellationToken)
     }
     // # --8<-- [end:UseEventHubsContainer]
 
+    protected virtual ValueTask DisposeAsyncCore()
+    {
+        return _eventHubsContainer.DisposeAsync();
+    }
+
     // # --8<-- [start:CreateEventHubsContainer]
     [UsedImplicitly]
     public sealed class EventHubsDefaultAzuriteConfiguration : EventHubsContainerTest

tests/Testcontainers.Kafka.Tests/KafkaContainerNetworkTest.cs

@@ -55,6 +55,7 @@ await _network.DisposeAsync()
     }
 
     [Fact]
+    [Trait(nameof(DockerCli.DockerPlatform), nameof(DockerCli.DockerPlatform.Linux))]
     public async Task ConsumesProducedKafkaMessage()
     {
         _ = await _kCatContainer.ExecAsync(new[] { "kafkacat", "-b", Listener, "-t", "msgs", "-P", "-l", DataFilePath }, TestContext.Current.CancellationToken)

tests/Testcontainers.Kafka.Tests/KafkaContainerRegistryTest.cs

@@ -77,6 +77,7 @@ await _network.DisposeAsync()
     }
 
     [Fact]
+    [Trait(nameof(DockerCli.DockerPlatform), nameof(DockerCli.DockerPlatform.Linux))]
     public async Task ConsumerReturnsProducerMessage()
     {
         // Given