Skip to content

Conversation

@felixb
Copy link
Contributor

@felixb felixb commented Jul 15, 2024

Description

Allow setting ipv6_address_preferred_lease_time dhcp options.

Motivation and Context

Longer lease times are more fault tolerant.

Breaking Changes

None.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request
  • I have applied the changes to a vpc running in my aws account w/o setting the new variable w/o changes.
  • I have applied the changes to a vpc running in my aws account w/ setting the new variable rolling out the the new dhcp options.

@felixb felixb changed the title feat: allow setting ipv6_address_preferred_lease_time dhcp options feat: Added ipv6_address_preferred_lease_time parameter to aws_vpc_dhcp_options resource Jul 15, 2024
@felixb
Copy link
Contributor Author

felixb commented Aug 2, 2024

@bryantbiggs any change of getting this merged? I'm using this in production for 3 weeks now.

@bryantbiggs bryantbiggs merged commit 3adb594 into terraform-aws-modules:master Aug 2, 2024
antonbabenko pushed a commit that referenced this pull request Aug 2, 2024
## [5.10.0](v5.9.0...v5.10.0) (2024-08-02)

### Features

* Added ipv6_address_preferred_lease_time parameter to aws_vpc_dhcp_options resource ([#1105](#1105)) ([3adb594](3adb594))
@antonbabenko
Copy link
Member

This PR is included in version 5.10.0 🎉

@github-actions
Copy link

github-actions bot commented Sep 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants