Skip to content

Commit 045dbce

Browse files
committed
Fix evict-on-finish change
1 parent a2e1f34 commit 045dbce

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

tests/Temporalio.Tests/Worker/WorkflowWorkerTests.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2997,6 +2997,10 @@ await ExecuteWorkerAsync<DynamicWorkflow>(
29972997
await handle.SignalAsync(wf => wf.SomeSignalAsync("signal arg"));
29982998
Assert.Equal("done", await handle.QueryAsync(wf => wf.SomeQuery("query arg")));
29992999
Assert.Equal("done", await handle.ExecuteUpdateAsync(wf => wf.SomeUpdateAsync("update arg")));
3000+
// Event list must be collected before the WF finishes, since when it finishes it
3001+
// will be evicted from the cache and the first query event will not exist upon
3002+
// replay.
3003+
var eventList = (await handle.QueryAsync(wf => wf.Events)).OrderBy(v => v).ToList();
30003004
await handle.SignalAsync(wf => wf.FinishAsync());
30013005
Assert.Equal("done", await handle.GetResultAsync());
30023006
Assert.Equal(
@@ -3008,7 +3012,7 @@ await ExecuteWorkerAsync<DynamicWorkflow>(
30083012
"update-SomeUpdate: update arg",
30093013
"workflow-NonDynamicWorkflow: workflow arg",
30103014
},
3011-
(await handle.QueryAsync(wf => wf.Events)).OrderBy(v => v).ToList());
3015+
eventList);
30123016
},
30133017
new TemporalWorkerOptions().AddActivity(DynamicWorkflow.DynamicActivity));
30143018
}
@@ -6042,4 +6046,4 @@ private async Task<TResult> ExecuteWorkerAsync<TWorkflow, TResult>(
60426046
using var worker = new TemporalWorker(client ?? Client, options);
60436047
return await worker.ExecuteAsync(() => action(worker));
60446048
}
6045-
}
6049+
}

0 commit comments

Comments
 (0)