-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.kind/questionIssues or PRs that are questions around the project or a particular featureIssues or PRs that are questions around the project or a particular featurepriority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Description
As of today, knative/pkg's code is the one responsible to register the webhook on kubernetes. This means, the following are possible :
- The webhook fails to start (for any reason), it does not get registered, thus it's not applied
- The webhook takes time to start (slow network, …), it's not registered quickly enough, a user can create resources
In all those cases, the user can end up creating resources that are either not valid or not mutated (with defaults values)
There is two way to fix these cases:
- Move the webhook registration in the
yamls, so that the webhook is registered as soon as the CRDs are created, before it started, and thus it will fail if the webhook is not running - Having the controller validate
I have a very very high preference for solution 1. .
dibyom
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.kind/questionIssues or PRs that are questions around the project or a particular featureIssues or PRs that are questions around the project or a particular featurepriority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.