SetDefaults for embedded specs (Pipeline, Task) 🥄

Embedded TaskSpec and PipelineSpec were not being *set defaults* when
the resource embedding it was. This fixes that.

Signed-off-by: Vincent Demeester <[email protected]>

Author: vdemeester

pkg/apis/pipeline/v1alpha1/pipeline_defaults.go

@@ -35,6 +35,9 @@ func (ps *PipelineSpec) SetDefaults(ctx context.Context) {
 				pt.TaskRef.Kind = NamespacedTaskKind
 			}
 		}
+		if pt.TaskSpec != nil {
+			pt.TaskSpec.SetDefaults(ctx)
+		}
 	}
 	for i := range ps.Params {
 		ps.Params[i].SetDefaults(ctx)

pkg/apis/pipeline/v1alpha1/pipelinerun_defaults.go

@@ -56,4 +56,8 @@ func (prs *PipelineRunSpec) SetDefaults(ctx context.Context) {
 	if prs.PodTemplate == nil {
 		prs.PodTemplate = defaultPodTemplate
 	}
+
+	if prs.PipelineSpec != nil {
+		prs.PipelineSpec.SetDefaults(ctx)
+	}
 }

pkg/apis/pipeline/v1beta1/pipeline_defaults.go

@@ -35,6 +35,9 @@ func (ps *PipelineSpec) SetDefaults(ctx context.Context) {
 				pt.TaskRef.Kind = NamespacedTaskKind
 			}
 		}
+		if pt.TaskSpec != nil {
+			pt.TaskSpec.SetDefaults(ctx)
+		}
 	}
 	for i := range ps.Params {
 		ps.Params[i].SetDefaults(ctx)

pkg/apis/pipeline/v1beta1/pipelinerun_defaults.go

@@ -56,4 +56,8 @@ func (prs *PipelineRunSpec) SetDefaults(ctx context.Context) {
 	if prs.PodTemplate == nil {
 		prs.PodTemplate = defaultPodTemplate
 	}
+
+	if prs.PipelineSpec != nil {
+		prs.PipelineSpec.SetDefaults(ctx)
+	}
 }

pkg/apis/pipeline/v1beta1/pipelinerun_defaults_test.go

@@ -119,6 +119,29 @@ func TestPipelineRunDefaulting(t *testing.T) {
 			},
 		},
 		wc: contexts.WithUpgradeViaDefaulting,
+	}, {
+		name: "Embedded PipelineSpec default",
+		in: &v1beta1.PipelineRun{
+			Spec: v1beta1.PipelineRunSpec{
+				PipelineSpec: &v1beta1.PipelineSpec{
+					Params: []v1beta1.ParamSpec{{
+						Name: "foo",
+					}},
+				},
+			},
+		},
+		want: &v1beta1.PipelineRun{
+			Spec: v1beta1.PipelineRunSpec{
+				PipelineSpec: &v1beta1.PipelineSpec{
+					Params: []v1beta1.ParamSpec{{
+						Name: "foo",
+						Type: "string",
+					}},
+				},
+				Timeout: &metav1.Duration{Duration: config.DefaultTimeoutMinutes * time.Minute},
+			},
+		},
+		wc: contexts.WithUpgradeViaDefaulting,
 	}, {
 		name: "PipelineRef default config context",
 		in: &v1beta1.PipelineRun{