Re-enable the helm test check

afrittoli · afrittoli · commit 6b8293bc28bb · 2020-05-20T13:19:46.000+01:00
The helm test was temporarily disabled until #2652 as merged. Re-nabled it now. Depends-on #2652
diff --git a/test/helm_task_test.go b/test/helm_task_test.go
@@ -95,8 +95,8 @@ func TestHelmDeployPipelineRun(t *testing.T) {
 
 	// Verify status of PipelineRun (wait for it)
 	if err := WaitForPipelineRunState(c, helmDeployPipelineRunName, timeout, PipelineRunSucceed(helmDeployPipelineRunName), "PipelineRunCompleted"); err != nil {
-		t.Logf("Error waiting for PipelineRun %s to finish: %s", helmDeployPipelineRunName, err)
-		t.Logf("PipelineRun execution failed; helm may or may not have been installed :(")
+		t.Errorf("Error waiting for PipelineRun %s to finish: %s", helmDeployPipelineRunName, err)
+		t.Fatalf("PipelineRun execution failed; helm may or may not have been installed :(")
 	}
 
 	// cleanup task to remove helm releases from cluster and cluster role bindings, will not fail the test if it fails, just log

Original file line number	Diff line number	Diff line change
`@@ -95,8 +95,8 @@ func TestHelmDeployPipelineRun(t *testing.T) {`
`95`	`95`
`96`	`96`	`// Verify status of PipelineRun (wait for it)`
`97`	`97`	`if err := WaitForPipelineRunState(c, helmDeployPipelineRunName, timeout, PipelineRunSucceed(helmDeployPipelineRunName), "PipelineRunCompleted"); err != nil {`
`98`		`- t.Logf("Error waiting for PipelineRun %s to finish: %s", helmDeployPipelineRunName, err)`
`99`		`- t.Logf("PipelineRun execution failed; helm may or may not have been installed :(")`
	`98`	`+ t.Errorf("Error waiting for PipelineRun %s to finish: %s", helmDeployPipelineRunName, err)`
	`99`	`+ t.Fatalf("PipelineRun execution failed; helm may or may not have been installed :(")`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`// cleanup task to remove helm releases from cluster and cluster role bindings, will not fail the test if it fails, just log`