Commit 2551443
committed
Remove conversion configuration for
`Cluster` only exists in `v1beta1` and will never have a `v1` thus
doesn't need to be registered in the conversion webhook.
Prior to this commit, some tooling (like
https://github.com/openshift/cluster-kube-apiserver-operator/) might
assume there is a conversion webhook and then fail to communicate with
it (because we do not register `ClusterTask` in the conversion webhook
part) ; generating a lot of spam log.
As a rules of thumb, if we are not registering/refering an object in
`newConversionController` (in `cmd/webhook/main.go`), the `conversion`
field in the CRD shouldn't be defined either.
Signed-off-by: Vincent Demeester <[email protected]>ClusterTask
1 parent e385556 commit 2551443
1 file changed
+0
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
0 commit comments