Bump github.com/sigstore/cosign/v2 from 2.5.3 to 2.6.0 #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XL
Proposing to bump the cosign version to include new library calls to push attestations with the referrer's API. - [Release notes](https://github.com/sigstore/cosign/releases/tag/v2.6.0) - [Changelog](https://github.com/sigstore/cosign/blob/6431af15a8066c4b33c7232fc2dba3f9278a16a5/CHANGELOG.md) - [Commits](sigstore/cosign@v2.5.3...v2.6.0) The new changes desired are sigstore/cosign/pull/4357 which should better support the work in tektoncd#1409. Signed-off-by: arewm <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
- Add LoadOption parameter to LoadPrivateKey calls in x509.go and clients.go - Pass nil for defaultLoadOptions to use sensible defaults (ED25519ph) - Update both production code and test code to match new API The LoadPrivateKey function signature changed in cosign v2.6.0 to include a third parameter for LoadOption configuration. Passing nil uses the default ED25519ph behavior which is appropriate for this use case. Co-authored-by: Claude Sonnet <[email protected]> Signed-off-by: arewm <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
arewm
force-pushed
the
cosign-v2.6.0
branch
from
d146dab to
cb9aa6c
Compare
Contributor
|
Linter is failing due to the known issue where it can't handle large PRs. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcarva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
Author
|
The second commit (cb9aa6c) is on top of updating the dependency as the interface did change a little bit. Locally, two tests failed but I am not sure if that is because I don't have sufficient configuration to run them (this brief summary was generated by Cursor): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Proposing to bump the cosign version to include new library calls to
push attestations with the referrer's API.
The new changes desired are sigstore/cosign#4357 which should
better support the work in #1409.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes