Skip to content

Conversation

@axe312ger
Copy link
Owner

The dependency to golang and the primitive package can be painful. Especially on CI where some services do not even support Go.

This will bundle primitive binaries with the package before pushing it to npm. It will contain binaries for 64bit windows, linux and osx. Other systems will still be supported except they will have to go the old way with installing go + primitive.

Implementation ideas welcome, the comments in the code should describe how I am planning to do it.

Best,
Benedikt

@axe312ger axe312ger changed the title [WIP] bundle primitive binaries [Ready to review] bundle primitive binaries Feb 26, 2018
@axe312ger
Copy link
Owner Author

I am done, it now does generate the binaries for primitive when doing npm install within the repo and before npm publish

@efegurkan ready to review. A release afterwards would be superb <3 :)

@efegurkan efegurkan merged commit 9c35882 into axe312ger:master Feb 27, 2018
@axe312ger axe312ger deleted the feat/bundle-primitive-binaries branch February 27, 2018 09:57
@axe312ger
Copy link
Owner Author

Awesome, thank you :)

Any chance to push this to npm as 0.3.0? :)

@efegurkan
Copy link
Collaborator

We were on it while you were writing it ;D

Thanks again for your awesome work!

Cheers,

@axe312ger
Copy link
Owner Author

🙇

@johanchouquet
Copy link

Hi there, thank you for this.

Any update on this topic ? I need this one :)!

@axe312ger
Copy link
Owner Author

@johanchouquet this was merged a year ago and is already released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants