Skip to content

Commit 2f71a12

Browse files
vermouth1992techkang
authored andcommitted
[ci] fix: use local models/configs/datasets to increase stability (volcengine#3616)
### What does this PR do? - As title ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
1 parent 9530472 commit 2f71a12

File tree

11 files changed

+37
-18
lines changed

11 files changed

+37
-18
lines changed
File renamed without changes.

.github/workflows/e2e_sppo.yml renamed to .github/workflows/.deprecate/e2e_sppo.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ jobs:
9595
pip3 install -e .[test,gpu,sglang]
9696
- name: Prepare MATH dataset
9797
run: |
98-
python3 examples/data_preprocess/math_dataset.py
98+
python3 examples/data_preprocess/math_dataset.py --local_dataset_path $HOME/models/hf_data/DigitalLearningGmbH/MATH-lighteval
9999
- name: Running the E2E test with the SPPO algorithm
100100
run: |
101101
ray stop --force

.github/workflows/model.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -171,14 +171,14 @@ jobs:
171171
run: |
172172
pip3 install --no-deps -e .[test]
173173
pip install --upgrade "huggingface_hub[cli]"
174-
- name: Download model config files
175-
run: |
176-
hf download Qwen/Qwen2.5-7B config.json --local-dir $HOME/configs/Qwen/Qwen2.5-7B
177-
hf download Qwen/Qwen3-8B config.json --local-dir $HOME/configs/Qwen/Qwen3-8B
178-
hf download deepseek-ai/deepseek-coder-1.3b-instruct config.json --local-dir $HOME/configs/deepseek-ai/deepseek-coder-1.3b-instruct
179-
hf download Qwen/Qwen2-57B-A14B config.json --local-dir $HOME/configs/Qwen/Qwen2-57B-A14B
180-
hf download Qwen/Qwen3-30B-A3B config.json --local-dir $HOME/configs/Qwen/Qwen3-30B-A3B
181-
hf download deepseek-ai/DeepSeek-V3-Base config.json --local-dir $HOME/configs/deepseek-ai/DeepSeek-V3-Base
174+
# - name: Download model config files
175+
# run: |
176+
# hf download Qwen/Qwen2.5-7B config.json --local-dir $HOME/configs/Qwen/Qwen2.5-7B
177+
# hf download Qwen/Qwen3-8B config.json --local-dir $HOME/configs/Qwen/Qwen3-8B
178+
# hf download deepseek-ai/deepseek-coder-1.3b-instruct config.json --local-dir $HOME/configs/deepseek-ai/deepseek-coder-1.3b-instruct
179+
# hf download Qwen/Qwen2-57B-A14B config.json --local-dir $HOME/configs/Qwen/Qwen2-57B-A14B
180+
# hf download Qwen/Qwen3-30B-A3B config.json --local-dir $HOME/configs/Qwen/Qwen3-30B-A3B
181+
# hf download deepseek-ai/DeepSeek-V3-Base config.json --local-dir $HOME/configs/deepseek-ai/DeepSeek-V3-Base
182182
- name: Running mcore config converter tests on 8 L20 GPUs
183183
run: |
184184
torchrun --nproc_per_node=8 tests/special_distributed/test_mcore_config_converter.py

.github/workflows/sgl.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,8 @@ jobs:
129129
python3 examples/data_preprocess/gsm8k.py --local_dataset_path ${HOME}/models/hf_data/gsm8k
130130
- name: Test the latest SGLang Rollout async with agent loop
131131
run: |
132-
huggingface-cli download verl-team/gsm8k-v0.4.1 --repo-type dataset --local-dir ~/verl-data/gsm8k
133132
ROLLOUT_NAME=sglang pytest -svvv tests/experimental/agent_loop
133+
# huggingface-cli download verl-team/gsm8k-v0.4.1 --repo-type dataset --local-dir ~/verl-data/gsm8k
134134
- name: Test the latest SGLang
135135
run: |
136136
cd tests/workers/rollout

.github/workflows/type-coverage-check.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ jobs:
2020

2121
- name: Install dependencies
2222
run: |
23-
pip install gitpython
24-
pip install -e .[sglang]
23+
pip3 install torch torchvision --index-url https://download.pytorch.org/whl/cpu
24+
pip3 install -r requirements.txt
25+
pip3 install -e . --no-deps
2526
- name: Run type annotation coverage check
2627
run: |
2728
python3 tests/special_sanity/type_coverage_check.py

examples/data_preprocess/math_dataset.py

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,28 @@ def extract_solution(solution_str):
3131

3232
if __name__ == "__main__":
3333
parser = argparse.ArgumentParser()
34-
parser.add_argument("--local_dir", default="~/data/math")
34+
parser.add_argument("--local_dir", default=None)
3535
parser.add_argument("--hdfs_dir", default=None)
36+
parser.add_argument("--local_dataset_path", default=None, help="The local path to the raw dataset, if it exists.")
37+
parser.add_argument(
38+
"--local_save_dir", default="~/data/math", help="The save directory for the preprocessed dataset."
39+
)
3640

3741
args = parser.parse_args()
42+
local_dataset_path = args.local_dataset_path
3843

3944
# 'lighteval/MATH' is no longer available on huggingface.
4045
# Use mirror repo: DigitalLearningGmbH/MATH-lighteval
4146
data_source = "DigitalLearningGmbH/MATH-lighteval"
4247
print(f"Loading the {data_source} dataset from huggingface...", flush=True)
43-
dataset = datasets.load_dataset(data_source, trust_remote_code=True)
48+
if local_dataset_path is not None:
49+
dataset = datasets.load_dataset(
50+
local_dataset_path,
51+
)
52+
else:
53+
dataset = datasets.load_dataset(
54+
data_source,
55+
)
4456

4557
train_dataset = dataset["train"]
4658
test_dataset = dataset["test"]
@@ -70,7 +82,13 @@ def process_fn(example, idx):
7082
train_dataset = train_dataset.map(function=make_map_fn("train"), with_indices=True)
7183
test_dataset = test_dataset.map(function=make_map_fn("test"), with_indices=True)
7284

73-
local_dir = os.path.expanduser(args.local_dir)
85+
local_save_dir = args.local_dir
86+
if local_save_dir is not None:
87+
print("Warning: Argument 'local_dir' is deprecated. Please use 'local_save_dir' instead.")
88+
else:
89+
local_save_dir = args.local_save_dir
90+
91+
local_dir = os.path.expanduser(local_save_dir)
7492
hdfs_dir = args.hdfs_dir
7593

7694
train_dataset.to_parquet(os.path.join(local_dir, "train.parquet"))

requirements-cuda.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
flash-attn

requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ accelerate
33
codetiming
44
datasets
55
dill
6-
flash-attn
76
hydra-core
87
liger-kernel
98
numpy<2.0.0

tests/special_distributed/test_fsdp_ckpt.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def test_fsdp_ckpt(strategy="fsdp"):
4949
local_rank, rank, world_size = initialize_global_process_group()
5050
device_mesh = init_device_mesh("cuda", mesh_shape=(world_size,), mesh_dim_names=("dp",))
5151

52-
model_name = "Qwen/Qwen2.5-0.5B-Instruct"
52+
model_name = os.path.expanduser("~/models/Qwen/Qwen2.5-0.5B-Instruct")
5353
config = Qwen2Config(num_hidden_layers=1)
5454

5555
with torch.device("cuda"):

0 commit comments

Comments
 (0)