Skip to content

Commit 27068fd

Browse files
tardis-keytechkang
authored andcommitted
[ci] chore: add codeowner (volcengine#3473)
### What does this PR do? add codeowner in npu folder /recipe/dapo and /examples/grpo_trainer: model scripts of npu /verl/models/transformers: npu_patch for transformers ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: ... - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
1 parent 36b0ccc commit 27068fd

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/CODEOWNERS

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,21 @@
22
/docs/amd_tutorial @yushengsu-thu
33
/docs/slang_multiturn @zhaochenyang20 @SwordFaith
44

5-
/recipe/dapo @tongyx361 @PeterSH6
5+
/recipe/dapo @tongyx361 @PeterSH6 @vermouth1992 @tardis-key @FightingZhen @ji-huazhong
66
/recipe/spin @zhaochenyang20
77
/recipe/sppo @zhaochenyang20
88

99
/third_party/sglang @zhaochenyang20 @SwordFaith
1010
/third_party/vllm @PeterSH6 @wuxibin89
11+
/examples/grpo_trainer @vermouth1992 @PeterSH6 @tardis-key @FightingZhen @ji-huazhong
1112
/verl/single_controller @zw0610 @wuxibin89 @hongpeng-guo
1213
/verl/trainer @eric-haibin-lin @vermouth1992 @tongyx361 @PeterSH6
1314
/verl/workers/engine @eric-haibin-lin @vermouth1992 @ZihengJiang
1415
/verl/workers/roles @eric-haibin-lin @vermouth1992 @ZihengJiang
1516
/verl/workers/engine/fsdp @eric-haibin-lin @vermouth1992 @ZihengJiang
1617
/verl/workers/rollout/vllm_rollout @wuxibin89 @PeterSH6 @chenhaiq
1718
/verl/workers/rollout/sglang_rollout @zhaochenyang20 @SwordFaith @chenhaiq
19+
/verl/models/transformers @vermouth1992 @PeterSH6 @tardis-key @FightingZhen @ji-huazhong
1820

1921
/tests/single_controller @zw0610 @wuxibin89
2022
/tests/trainer @eric-haibin-lin @vermouth1992 @tongyx361 @PeterSH6

0 commit comments

Comments
 (0)