Skip to content

Commit c230911

Browse files
anbaMs2ger
authored andcommitted
Prefer "islamic-tbla" over "islamic" for Hijri calendars
"islamic" is underspecified because it doesn't include any information which location and algorithms should be used to approximate new moon observations. Instead switch to "islamic-tbla".
1 parent c7bbdd4 commit c230911

6 files changed

Lines changed: 23 additions & 23 deletions

File tree

test/intl402/Temporal/Instant/prototype/toLocaleString/dateStyle.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
/*---
55
esid: sec-temporal.instant.prototype.tolocalestring
66
description: Basic tests that dateStyle option affects output
7-
locale: [en-u-ca-gregory, en-u-ca-islamic]
7+
locale: [en-u-ca-gregory, en-u-ca-islamic-tbla]
88
features: [Temporal, Intl.DateTimeFormat-datetimestyle]
99
---*/
1010

@@ -19,10 +19,10 @@ assert(
1919
"dateStyle: short does not write month of March out in full"
2020
);
2121
assert(
22-
instant.toLocaleString("en-u-ca-islamic", { dateStyle: "long" }).includes("Ramadan"),
22+
instant.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "long" }).includes("Ramadan"),
2323
"dateStyle: long writes month of Ramadan out in full"
2424
);
2525
assert(
26-
!instant.toLocaleString("en-u-ca-islamic", { dateStyle: "short" }).includes("Ramadan"),
26+
!instant.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "short" }).includes("Ramadan"),
2727
"dateStyle: short does not write month of Ramadan out in full"
2828
);

test/intl402/Temporal/PlainDate/prototype/toLocaleString/dateStyle.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
/*---
55
esid: sec-temporal.plaindate.prototype.tolocalestring
66
description: Basic tests that dateStyle option affects output
7-
locale: [en-u-ca-gregory, en-u-ca-islamic]
7+
locale: [en-u-ca-gregory, en-u-ca-islamic-tbla]
88
features: [Temporal, Intl.DateTimeFormat-datetimestyle]
99
---*/
1010

@@ -19,13 +19,13 @@ assert(
1919
"dateStyle: short does not write month of March out in full"
2020
);
2121

22-
const dateIslamic = new Temporal.PlainDate(2024, 3, 26, "islamic");
22+
const dateIslamic = new Temporal.PlainDate(2024, 3, 26, "islamic-tbla");
2323

2424
assert(
25-
dateIslamic.toLocaleString("en-u-ca-islamic", { dateStyle: "long" }).includes("Ramadan"),
25+
dateIslamic.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "long" }).includes("Ramadan"),
2626
"dateStyle: long writes month of Ramadan out in full"
2727
);
2828
assert(
29-
!dateIslamic.toLocaleString("en-u-ca-islamic", { dateStyle: "short" }).includes("Ramadan"),
29+
!dateIslamic.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "short" }).includes("Ramadan"),
3030
"dateStyle: short does not write month of Ramadan out in full"
3131
);

test/intl402/Temporal/PlainDateTime/prototype/toLocaleString/dateStyle.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
/*---
55
esid: sec-temporal.plaindatetime.prototype.tolocalestring
66
description: Basic tests that dateStyle option affects output
7-
locale: [en-u-ca-gregory, en-u-ca-islamic]
7+
locale: [en-u-ca-gregory, en-u-ca-islamic-tbla]
88
features: [Temporal, Intl.DateTimeFormat-datetimestyle]
99
---*/
1010

@@ -19,13 +19,13 @@ assert(
1919
"dateStyle: short does not write month of March out in full"
2020
);
2121

22-
const dateIslamic = new Temporal.PlainDateTime(2024, 3, 26, 10, 30, 0, 0, 0, 0, "islamic");
22+
const dateIslamic = new Temporal.PlainDateTime(2024, 3, 26, 10, 30, 0, 0, 0, 0, "islamic-tbla");
2323

2424
assert(
25-
dateIslamic.toLocaleString("en-u-ca-islamic", { dateStyle: "long" }).includes("Ramadan"),
25+
dateIslamic.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "long" }).includes("Ramadan"),
2626
"dateStyle: long writes month of Ramadan out in full"
2727
);
2828
assert(
29-
!dateIslamic.toLocaleString("en-u-ca-islamic", { dateStyle: "short" }).includes("Ramadan"),
29+
!dateIslamic.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "short" }).includes("Ramadan"),
3030
"dateStyle: short does not write month of Ramadan out in full"
3131
);

test/intl402/Temporal/PlainMonthDay/prototype/toLocaleString/dateStyle.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
/*---
55
esid: sec-temporal.plainmonthday.prototype.tolocalestring
66
description: Basic tests that dateStyle option affects output
7-
locale: [en-u-ca-gregory, en-u-ca-islamic]
7+
locale: [en-u-ca-gregory, en-u-ca-islamic-tbla]
88
features: [Temporal, Intl.DateTimeFormat-datetimestyle]
99
---*/
1010

@@ -19,13 +19,13 @@ assert(
1919
"dateStyle: short does not write month of March out in full"
2020
);
2121

22-
const dateIslamic = Temporal.PlainMonthDay.from({ monthCode: "M09", day: 16, calendar: "islamic" });
22+
const dateIslamic = Temporal.PlainMonthDay.from({ monthCode: "M09", day: 16, calendar: "islamic-tbla" });
2323

2424
assert(
25-
dateIslamic.toLocaleString("en-u-ca-islamic", { dateStyle: "long" }).includes("Ramadan"),
25+
dateIslamic.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "long" }).includes("Ramadan"),
2626
"dateStyle: long writes month of Ramadan out in full"
2727
);
2828
assert(
29-
!dateIslamic.toLocaleString("en-u-ca-islamic", { dateStyle: "short" }).includes("Ramadan"),
29+
!dateIslamic.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "short" }).includes("Ramadan"),
3030
"dateStyle: short does not write month of Ramadan out in full"
3131
);

test/intl402/Temporal/PlainYearMonth/prototype/toLocaleString/dateStyle.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
/*---
55
esid: sec-temporal.plainyearmonth.prototype.tolocalestring
66
description: Basic tests that dateStyle option affects output
7-
locale: [en-u-ca-gregory, en-u-ca-islamic]
7+
locale: [en-u-ca-gregory, en-u-ca-islamic-tbla]
88
features: [Temporal, Intl.DateTimeFormat-datetimestyle]
99
---*/
1010

@@ -19,13 +19,13 @@ assert(
1919
"dateStyle: short does not write month of March out in full"
2020
);
2121

22-
const dateIslamic = Temporal.PlainYearMonth.from({ year: 1445, monthCode: "M09", calendar: "islamic" });
22+
const dateIslamic = Temporal.PlainYearMonth.from({ year: 1445, monthCode: "M09", calendar: "islamic-tbla" });
2323

2424
assert(
25-
dateIslamic.toLocaleString("en-u-ca-islamic", { dateStyle: "long" }).includes("Ramadan"),
25+
dateIslamic.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "long" }).includes("Ramadan"),
2626
"dateStyle: long writes month of Ramadan out in full"
2727
);
2828
assert(
29-
!dateIslamic.toLocaleString("en-u-ca-islamic", { dateStyle: "short" }).includes("Ramadan"),
29+
!dateIslamic.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "short" }).includes("Ramadan"),
3030
"dateStyle: short does not write month of Ramadan out in full"
3131
);

test/intl402/Temporal/ZonedDateTime/prototype/toLocaleString/dateStyle.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
/*---
55
esid: sec-temporal.plaindate.prototype.tolocalestring
66
description: Basic tests that dateStyle option affects output
7-
locale: [en-u-ca-gregory, en-u-ca-islamic]
7+
locale: [en-u-ca-gregory, en-u-ca-islamic-tbla]
88
features: [Temporal, Intl.DateTimeFormat-datetimestyle]
99
---*/
1010

@@ -19,13 +19,13 @@ assert(
1919
"dateStyle: short does not write month of March out in full"
2020
);
2121

22-
const dateIslamic = new Temporal.ZonedDateTime(1711475200_000_000_000n, "UTC", "islamic");
22+
const dateIslamic = new Temporal.ZonedDateTime(1711475200_000_000_000n, "UTC", "islamic-tbla");
2323

2424
assert(
25-
dateIslamic.toLocaleString("en-u-ca-islamic", { dateStyle: "long" }).includes("Ramadan"),
25+
dateIslamic.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "long" }).includes("Ramadan"),
2626
"dateStyle: long writes month of Ramadan out in full"
2727
);
2828
assert(
29-
!dateIslamic.toLocaleString("en-u-ca-islamic", { dateStyle: "short" }).includes("Ramadan"),
29+
!dateIslamic.toLocaleString("en-u-ca-islamic-tbla", { dateStyle: "short" }).includes("Ramadan"),
3030
"dateStyle: short does not write month of Ramadan out in full"
3131
);

0 commit comments

Comments
 (0)