Skip to content

Add PromiseCapability wrapper around sync dispose used in an await using #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Add PromiseCapability wrapper around sync dispose used in an await using #218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f09a8b9
Add PromiseCapability wrapper around sync dispose used in an `await u…
rbuckton Mar 22, 2024
f7f580e
Merge branch 'main' into async-from-sync-dispose
rbuckton Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions spec.emu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,9 +1068,12 @@ contributors: Ron Buckton, Ecma International
1. If _method_ is not *undefined*, then
1. Let _closure_ be a new Abstract Closure with no parameters that captures _method_ and performs the following steps when called:
1. Let _O_ be the *this* value.
1. Perform ? Call(_method_, _O_).
1. Return *undefined*.
1. NOTE: This function is not observable to user code. It is used to ensure that a Promise returned from a synchronous `@@dispose` method will not be awaited.
1. Let _promiseCapability_ be ! NewPromiseCapability(%Promise%).
1. Let _result_ be Completion(Call(_method_, _O_)).
1. IfAbruptRejectPromise(_result_, _promiseCapability_).
1. Perform ? Call(_promiseCapability_.[[Resolve]], *undefined*, « *undefined* »).
1. Return _promiseCapability_.[[Promise]].
1. NOTE: This function is not observable to user code. It is used to ensure that a Promise returned from a synchronous `@@dispose` method will not be awaited and that any exception thrown will not be thrown synchronously.
1. Return CreateBuiltinFunction(_closure_, 0, *""*, « »).
1. Else,
1. Let _method_ be ? GetMethod(_V_, @@dispose).
Expand Down